Skip to content

Fix 0 value in range field#24939

Merged
HLeithner merged 1 commit intojoomla:stagingfrom
SharkyKZ:j3/rangeField
May 18, 2019
Merged

Fix 0 value in range field#24939
HLeithner merged 1 commit intojoomla:stagingfrom
SharkyKZ:j3/rangeField

Conversation

@SharkyKZ
Copy link
Copy Markdown
Contributor

@SharkyKZ SharkyKZ commented May 17, 2019 •
edited
Loading

Pull Request for Issue #24938 .

Summary of Changes

Fixes 0 value usage in range field.

Testing Instructions

Add range field with default value 0 to any form:

<field 
	name="testrange" 
	type="range" 
	label="Test Range" 
	description="Test range desc" 
	min="-10" 
	max="10"
	step="0.1" 
	class="" 
	default="0"
/>

View the form. Look at the field.

Expected result

Slider is at 0 value (centered).

Actual result

Slider is at -10 value (left).

Documentation Changes Required

No.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented May 17, 2019

I have tested this item ✅ successfully on fcc96ac

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24939.

@ghost
Copy link
Copy Markdown

ghost commented May 17, 2019

@thednp please test > https://docs.joomla.org/Testing_Joomla!_patches

@thednp
Copy link
Copy Markdown
Contributor

thednp commented May 17, 2019

@franz-wohlkoenig I tested the change directly into the code, it fixes the issue.

@alikon
Copy link
Copy Markdown
Contributor

alikon commented May 17, 2019

I have tested this item ✅ successfully on fcc96ac

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24939.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented May 17, 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24939.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 17, 2019
@HLeithner HLeithner merged commit 7a4f97f into joomla:staging May 18, 2019
@HLeithner HLeithner added this to the Joomla 3.9.7 milestone May 18, 2019
@HLeithner
Copy link
Copy Markdown
Member

HLeithner commented May 18, 2019

thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 18, 2019
tecpromotion pushed a commit to tecpromotion/joomla-cms that referenced this pull request May 23, 2019
@SharkyKZ @tecpromotion
Fix 0 value in range field (joomla#24939)
5bb51e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 3.9.7

Development

Successfully merging this pull request may close these issues.

6 participants

@SharkyKZ @Quy @thednp @alikon @HLeithner @joomla-cms-bot