RTL Text align right for select Modules list#24722
Merged
SniperSister merged 6 commits intojoomla:stagingfrom May 8, 2019
Merged
RTL Text align right for select Modules list#24722SniperSister merged 6 commits intojoomla:stagingfrom
SniperSister merged 6 commits intojoomla:stagingfrom
Conversation
Contributor
|
this pr seem's not present on the issue tracker btw i've tested it successfully |
|
@infograf768 can you please have a look as PR can't be altered test: |
Contributor
|
some synch glitch happening here now i'm able to see this pr on issue tracker but still unable to mark as tested successfully |
Member
Author
|
no idea why it does not sync. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24722. |
Contributor
|
Thanks, merged! |
tecpromotion
pushed a commit
to tecpromotion/joomla-cms
that referenced
this pull request
May 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Displaying correctly the list of Modules when selecting a new module.
The existing display code dated back from 2012 when it was necessary to order stuff differently.
Testing Instructions
Install Arabic or Persian language.
Switch to that language in admin
administrator/index.php?option=com_modules&view=select
Before patch
After patch