Skip to content

Update to default.php: removed nowrap class to allow wrapping title…#24712

Merged
SniperSister merged 3 commits intojoomla:stagingfrom
kofaysi:staging
May 16, 2019
Merged

Update to default.php: removed nowrap class to allow wrapping title…#24712
SniperSister merged 3 commits intojoomla:stagingfrom
kofaysi:staging

Conversation

@kofaysi
Copy link
Copy Markdown
Contributor

@kofaysi kofaysi commented Apr 24, 2019

…and alias

Pull Request for Issue #24650.

Testing Instructions

Create a contact with a name/title of 200+ characters

Expected result

The title and the alias will wrap, long words will break.

Actual result

The title and the alias does not wrap and pushes other parameters (access, hits, language, ID) behind the right edge of the screen.

Documentation Changes Required

IDK about any.

…nd alias

Removed nowrap class from the table cell definition for the name and the alias of a contact.
@ghost
Copy link
Copy Markdown

ghost commented Apr 24, 2019

I have tested this item 🔴 unsuccessfully on 2643f7a

Without PR

Screen Shot 2019-04-24 at 08 49 21

With PR

Screen Shot 2019-04-24 at 08 49 52


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24712.

@kofaysi
Copy link
Copy Markdown
Contributor Author

kofaysi commented Apr 24, 2019

a break-word class has to be added a line below the current change
<div class="pull-left break-word">
But I do not understand how can I change the existing PR. I can create a new PR, but is that the right approach?

@ghost
Copy link
Copy Markdown

ghost commented Apr 24, 2019

i don't know but pretts aure a dev will answer.

@hardik-codes
Copy link
Copy Markdown
Contributor

hardik-codes commented Apr 24, 2019

@kofaysi you can do the changes on your local machine and then push those changes. In this way a new commit will be added to the existing PR

If you are finding it difficult and if you want I can do a PR for you with your suggested changes

@kofaysi
Copy link
Copy Markdown
Contributor Author

kofaysi commented Apr 24, 2019

Unfortunately, I'm making changes and PRs through the web interface. Looking into the existing PR, I cannot make changes to the code.

So, please, if you feel so, make a change. Thank you!

@brianteeman
Copy link
Copy Markdown
Contributor

Go to https://github.com/kofaysi/joomla-cms

Select the branch - in this case it is staging

Make the changes you want there and they will appear here

@hardik-codes
Copy link
Copy Markdown
Contributor

@kofaysi you can follow what @brianteeman suggested

Added break-word class to allow for word break.
@kofaysi
Copy link
Copy Markdown
Contributor Author

kofaysi commented Apr 24, 2019

Thank you for the suggestion. Changes are made and pushed. (Well, that was very straightforward.)

@ghost
Copy link
Copy Markdown

ghost commented Apr 24, 2019

I have tested this item ✅ successfully on 1314cc9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24712.

@brianteeman
Copy link
Copy Markdown
Contributor

@kofaysi glad you worked it out.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented May 10, 2019

I have tested this item ✅ successfully on 1314cc9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24712.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented May 10, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24712.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 10, 2019
@SniperSister SniperSister merged commit f6efc5a into joomla:staging May 16, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 16, 2019
@SniperSister
Copy link
Copy Markdown
Contributor

Merged, thank you for contribution, it's much appreciated!

@SniperSister SniperSister added this to the Joomla 3.9.7 milestone May 16, 2019
tecpromotion pushed a commit to tecpromotion/joomla-cms that referenced this pull request May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants