Skip to content

Add PHP 7.2 and 7.3 to AppVeyor#24512

Merged
HLeithner merged 6 commits intojoomla:stagingfrom
J0WI:win-php7
May 8, 2019
Merged

Add PHP 7.2 and 7.3 to AppVeyor#24512
HLeithner merged 6 commits intojoomla:stagingfrom
J0WI:win-php7

Conversation

@J0WI
Copy link
Copy Markdown
Contributor

@J0WI J0WI commented Apr 5, 2019

Summary of Changes

This enables tests for PHP 7.2 and 7.3 to AppVeyor.
I also changed the downloads to use a secure connection.

There are no changes expected and no further testing is required to apply this patch.

Edit: I actually had to refactor some environment variables to ensure compatibility with each version. Fell free to squash my commits.

@HLeithner
Copy link
Copy Markdown
Member

@rdeutz @yvesh can you comment this?

@ghost ghost removed the J3 Issue label Apr 19, 2019
@ghost
Copy link
Copy Markdown

ghost commented Apr 24, 2019

Reminder for @rdeutz @yvesh

@SniperSister
Copy link
Copy Markdown
Contributor

/cc @HLeithner @Hackwar

@HLeithner HLeithner merged commit dc7c6f6 into joomla:staging May 8, 2019
@HLeithner
Copy link
Copy Markdown
Member

Thx

@HLeithner HLeithner added this to the Joomla 3.9.7 milestone May 8, 2019
@J0WI J0WI deleted the win-php7 branch May 8, 2019 20:13
tecpromotion pushed a commit to tecpromotion/joomla-cms that referenced this pull request May 23, 2019
wilsonge added a commit that referenced this pull request Jun 11, 2019
This is a partial port of #24512 from staging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants