Skip to content

Add label tag#24482

Merged
SniperSister merged 4 commits intojoomla:stagingfrom
hardik-codes:labelTag
May 7, 2019
Merged

Add label tag#24482
SniperSister merged 4 commits intojoomla:stagingfrom
hardik-codes:labelTag

Conversation

@hardik-codes
Copy link
Copy Markdown
Contributor

@hardik-codes hardik-codes commented Apr 4, 2019

Pull Request for Issue #24467

Summary of Changes

Add label tag to search field

Testing Instructions

Code Inspection

Documentation Changes Required

None

@ghost ghost mentioned this pull request Apr 4, 2019
Closed
@hardik-codes
Copy link
Copy Markdown
Contributor Author

hardik-codes commented Apr 4, 2019

@zwiastunsw please test

@ghost ghost added J3 Issue and removed J3 Issue labels Apr 5, 2019
@tahseen-fathima98
Copy link
Copy Markdown

tahseen-fathima98 commented Apr 7, 2019

Where can i see the code and try to do the changes in it?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24482.

@ghost
Copy link
Copy Markdown

ghost commented Apr 7, 2019 •
edited by ghost
Loading

I guess you mean doing a Test so please read https://brian.teeman.net/joomla/873-a-dummies-guide-to-joomla-bug-testing or https://docs.joomla.org/Testing_Joomla!_patches

Quy
Quy reviewed Apr 14, 2019
View reviewed changes
@hardik-codes
fix
f44b2b1 
Co-Authored-By: hardik-codes <hardik06agarwal@gmail.com>
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Apr 14, 2019

I have tested this item ✅ successfully on f44b2b1

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24482.

@ghost ghost added the a11y Accessibility label Apr 14, 2019
@hardik-codes
Copy link
Copy Markdown
Contributor Author

hardik-codes commented Apr 15, 2019

one more tester please

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Apr 15, 2019

@hardik-codes please dont keep requesting tests. When people have the time they will test.

@HLeithner
Copy link
Copy Markdown
Member

HLeithner commented Apr 15, 2019

@hardik-codes you can join the joomla bug squad and talk to people or ask students of the gsoc project to test PRs in the gsoc glip chat. Ping me on glip.

@hardik-codes
Copy link
Copy Markdown
Contributor Author

hardik-codes commented Apr 15, 2019

@hardik-codes please dont keep requesting tests. When people have the time they will test.

I'm really sorry about that. Will keep this in mind from next time onwards

@hardik-codes
Copy link
Copy Markdown
Contributor Author

hardik-codes commented Apr 15, 2019

@hardik-codes you can join the joomla bug squad and talk to people or ask students of the gsoc project to test PRs in the gsoc glip chat. Ping me on glip.

sure

@zwiastunsw
Copy link
Copy Markdown
Contributor

zwiastunsw commented Apr 15, 2019

I have tested this item ✅ successfully on f44b2b1

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24482.

@ghost ghost removed the a11y Accessibility label Apr 15, 2019
@ghost
Copy link
Copy Markdown

ghost commented Apr 15, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 15, 2019
@ghost ghost added the a11y Accessibility label Apr 18, 2019
@ghost ghost changed the title [staging] [a11y] Add label tag Add label tag Apr 18, 2019
@ghost ghost removed the J3 Issue label Apr 19, 2019
@SniperSister SniperSister merged commit 1dfc4d8 into joomla:staging May 7, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 7, 2019
@SniperSister
Copy link
Copy Markdown
Contributor

SniperSister commented May 7, 2019

Merged! Thanks a lot :)

@SniperSister SniperSister added this to the Joomla 3.9.7 milestone May 7, 2019
tecpromotion pushed a commit to tecpromotion/joomla-cms that referenced this pull request May 23, 2019
@hardik-codes @tecpromotion
Add label tag to com_search search field (joomla#24482)
58b08e2 
* Added label tag to com_search search field

Co-Authored-By: hardik-codes <hardik06agarwal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quy Quy Quy left review comments

Assignees

No one assigned

Labels

a11y Accessibility

Projects

None yet

Milestone

Joomla 3.9.7

Development

Successfully merging this pull request may close these issues.

9 participants

@hardik-codes @tahseen-fathima98 @Quy @brianteeman @HLeithner @zwiastunsw @SniperSister @joomla-cms-bot @jeckodevelopment