Skip to content

use the index for session table#23650

Merged
HLeithner merged 18 commits intojoomla:stagingfrom
alikon:patch-109
May 11, 2019
Merged

use the index for session table#23650
HLeithner merged 18 commits intojoomla:stagingfrom
alikon:patch-109

Conversation

@alikon
Copy link
Copy Markdown
Contributor

@alikon alikon commented Jan 23, 2019

Pull Request for Issue #22632 .

Summary of Changes

just completing the work made in #22668 for supported db's

Testing Instructions

see #22668

Expected result

screenshot from 2019-01-23 19-05-49

Actual result

screenshot from 2019-01-23 19-06-26

@lucasacchiricciardi
Copy link
Copy Markdown

I have tested this item ✅ successfully on cd9752f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23650.

2 similar comments
@davidemessia
Copy link
Copy Markdown

I have tested this item ✅ successfully on cd9752f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23650.

@faustonenci
Copy link
Copy Markdown

I have tested this item ✅ successfully on cd9752f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23650.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Feb 23, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23650.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 23, 2019
@alikon alikon changed the title [sql] use the index for seesion table [sql] use the index for session table Apr 2, 2019
@ghost ghost added J3 Issue and removed J3 Issue labels Apr 5, 2019
@ghost ghost changed the title [sql] use the index for session table use the index for session table Apr 19, 2019
@ghost ghost removed the J3 Issue label Apr 19, 2019
@HLeithner
Copy link
Copy Markdown
Member

@alikon could you rebase this for 3.9.7 please

@alikon
Copy link
Copy Markdown
Contributor Author

alikon commented Apr 23, 2019

@HLeithner done ;)

@richard67
Copy link
Copy Markdown
Member

@HLeithner This PR had 2 good tests and then was set to RTC. Since this time, only rebase has happened, no further changes. So I think the good tests and RTC status is still valid, it does not need to be re-tested. In addition, I've checked by code review that the database changes are right and consistent, and that the schema update scripts have the right file name for 3.9.7. => Please set RTC again.

@ghost
Copy link
Copy Markdown

ghost commented May 11, 2019

@richard67 set back on pending and RTC again.

@richard67
Copy link
Copy Markdown
Member

richard67 commented May 11, 2019

@franz-wohlkoenig Issue tracker shows failure status for some reason.

Update: Seems to be some old drone status shown in issue tracker which was not related to this PR but to javascript stuff.

@ghost
Copy link
Copy Markdown

ghost commented May 11, 2019

Issue tracker shows failure status for some reason.

have seen but don't know why. That kind of failure happen sometimes but other doing merge know if this is a Probem or not.

@HLeithner HLeithner merged commit 1c5551a into joomla:staging May 11, 2019
@HLeithner
Copy link
Copy Markdown
Member

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 11, 2019
@HLeithner HLeithner added this to the Joomla 3.9.7 milestone May 11, 2019
@alikon alikon deleted the patch-109 branch May 12, 2019 05:37
tecpromotion pushed a commit to tecpromotion/joomla-cms that referenced this pull request May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants