Skip to content

[4.0] Fix Legacy Model loading. Fixes #23517#23525

Merged
wilsonge merged 4 commits intojoomla:4.0-devfrom
wilsonge:legacy-loading
Jan 13, 2019
Merged

[4.0] Fix Legacy Model loading. Fixes #23517#23525
wilsonge merged 4 commits intojoomla:4.0-devfrom
wilsonge:legacy-loading

Conversation

@wilsonge
Copy link
Copy Markdown
Contributor

@wilsonge wilsonge commented Jan 12, 2019 •
edited
Loading

See #23517 for test instructions. Note you must test with an extension that hasn't been namespaced and uses core MVC

@wilsonge wilsonge mentioned this pull request Jan 12, 2019
Closed
Quy
Quy reviewed Jan 12, 2019
View reviewed changes
Quy and others added 2 commits January 12, 2019 22:03
@PhocaCz
Copy link
Copy Markdown
Contributor

PhocaCz commented Jan 13, 2019

I have tested this item ✅ successfully on efbeebb

Tested on Joomla! 4.0.0-alpha7-dev

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23525.

@wilsonge wilsonge changed the title Fix Legacy Model loading. Fixes #23517 [4.0] Fix Legacy Model loading. Fixes #23517 Jan 13, 2019
@ChristineWk
Copy link
Copy Markdown

ChristineWk commented Jan 13, 2019

I have tested this item ✅ successfully on efbeebb

Tested on alpha-7 with new installation of extension Phocadownload.
But: I did'nt get the failure as shown in #23525. Phocadownload > Files, I got:
An error has occurred.

0 Call to a member function get() on null

After using the Patch, above message has gone.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23525.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 13, 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23525.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 13, 2019
@ChristineWk
Copy link
Copy Markdown

ChristineWk commented Jan 13, 2019

Checked again, because first test was only with "Files" but now, all: (present status):
Files / Categories / Licenses / Downloads / Uploads / File Rating / Styles
0 Call to a member function get() on null

Layout
Call to a member function getTable() on boolean and:
Warning: Invalid argument supplied for foreach() in /.../administrator/components/com_phocadownload/views/phocadownloadstat/view.html.php on line 28 Warning: count(): Parameter must be an array or an object that implements Countable in .../administrator/components/com_phocadownload/views/phocadownloadstat/view.html.php on line 36

after Patch; both messages has gone

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23525.

@wilsonge wilsonge merged commit c9e15d6 into joomla:4.0-dev Jan 13, 2019
@wilsonge wilsonge deleted the legacy-loading branch January 13, 2019 19:14
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 13, 2019
@wilsonge
Copy link
Copy Markdown
Contributor Author

wilsonge commented Jan 13, 2019

Thanks guys :)

@wilsonge wilsonge added this to the Joomla 4.0 milestone Jan 13, 2019
@wilsonge wilsonge mentioned this pull request Mar 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quy Quy Quy left review comments

@laoneo laoneo laoneo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 4.0

Development

Successfully merging this pull request may close these issues.

6 participants

@wilsonge @PhocaCz @ChristineWk @Quy @laoneo @joomla-cms-bot