Preparing 3.10 for 4.0 content versioning#23479
Merged
zero-24 merged 9 commits intojoomla:3.10-devfrom Dec 19, 2019
Merged
Conversation
Member
Author
|
The original PR to refactor the versioning feature is #23432. |
Contributor
|
Merging for 3.10 thanks @Hackwar |
Member
Author
|
This has not been merged into 4.0, so it seems not a good idea to merge this into 3.10 |
zero-24
added a commit
that referenced
this pull request
Dec 19, 2019
Contributor
|
Done thanks. |
Member
Author
|
Hey, yeah, so... We actually did merge in this feature shortly before the beta release, so we need to add this to 3.10 again... |
Contributor
|
Can you do a PR and tag me? I'm happy to review and merge as this PR here has been reverted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports a few classes that would be necessary to implement versioning of content items in the same code for extensions in 3.x and 4.0. To support both 3.x-style and 4.0-style versioning, you'd have to implement the 3.x-style first. Good luck with that. To get 4.0-style working, simply let your table class implement the interface VersionableTableInterface (and the method that that defines) and let your item controller and model use the respective Versionable trait. In 3.x, these traits are empty, in 4.0 they contain all the logic necessary for versioning.