Skip to content

[4.0] Workflow article buttons#22393

Merged
wilsonge merged 82 commits intojoomla:4.0-devfrom
bembelimen:workflow-article-buttons
Dec 25, 2018
Merged

[4.0] Workflow article buttons#22393
wilsonge merged 82 commits intojoomla:4.0-devfrom
bembelimen:workflow-article-buttons

Conversation

@bembelimen
Copy link
Copy Markdown
Contributor

@bembelimen bembelimen commented Sep 26, 2018 •
edited
Loading

Pull Request for Issue #21818 #21708 #21527 .

Summary of Changes

Based on the PR #21247 the action buttons (publish, unpublish, archive, trash) are readded and grouped.

First we need this PR to have all buttons in place: #21532 so perhaps someone could reactivate it.

Thanks to @lavipr for the JS code and @ciar4n for the main idea.

Testing Instructions

  1. Create several workflows
  2. Create articles
  3. Try out the differnt buttons

Expected result

Articles change stage by pressing the buttons

--
Cleaning the JS file atm.

ciar4n and others added 30 commits July 24, 2018 14:20
@ciar4n
Group toolbar buttons [com-content -> articles]
47fc7c1
@Fedik
Handle a disabled state for anchors
9b3a538
@Fedik
Make a root button of the dropdown to respect listCheck option
b0de884
@ciar4n
Merge pull request #4 from Fedik/pull21247-2
d032f00 
Handle a disabled state for anchors
@ciar4n
Change anchor to button
63ccd55
@ciar4n
Grey disabled
04bead9
@ciar4n
Happy hound
b5fb61b
@ciar4n
Merge branch '4.0-dev' into toolbar-articles
fd84ccc
@ciar4n
Use [disabled]
8795373
@ciar4n
Merge branch 'toolbar-articles' of https://github.com/ciar4n/joomla-cms…
892d377 
… into toolbar-articles
@ciar4n
Merge branch '4.0-dev' of https://github.com/joomla/joomla-cms into t…
d23fd84 
…oolbar-articles
@ciar4n
Revert "Merge branch '4.0-dev' of https://github.com/joomla/joomla-cms …
f948490 
…into toolbar-articles"

This reverts commit d23fd84, reversing
changes made to 892d377.
@ciar4n
Merge branch '4.0-dev' of https://github.com/joomla/joomla-cms into t…
6260911 
…oolbar-articles
@ciar4n
Merge branch '4.0-dev' of https://github.com/joomla/joomla-cms into t…
9285265 
…oolbar-articles
@ciar4n
Merge branch '4.0-dev' of https://github.com/joomla/joomla-cms into t…
02aa5c7 
…oolbar-articles
@ciar4n
Merge branch '4.0-dev' of https://github.com/joomla/joomla-cms into t…
bb52602 
…oolbar-articles
@ciar4n
Merge branch '4.0-dev' into toolbar-articles
cbd0c87
@ciar4n
fixes
91cff1a
@ciar4n
Remove publish/trash/archive
c257e72
@ciar4n
Set border color to disabled button
00d2207
@ciar4n
happy hound
15f1fab
@ciar4n
Merge branch '4.0-dev' of https://github.com/joomla/joomla-cms into t…
cbb71ea 
…oolbar-articles
@bembelimen
Merge branch '4.0-dev' of github.com:joomla/joomla-cms into toolbar-a…
650e984 
…rticles

# Conflicts:
#	administrator/templates/atum/css/template-rtl.css
#	administrator/templates/atum/css/template-rtl.min.css
#	administrator/templates/atum/css/template.css
#	administrator/templates/atum/css/template.min.css
#	layouts/joomla/toolbar/dropdown.php
#	libraries/src/Toolbar/ToolbarButton.php
#	plugins/editors/tinymce/tinymce.xml
#	templates/cassiopeia/css/template-rtl.css
#	templates/cassiopeia/css/template.css
@bembelimen
Add buttons and indicator for possible conditions
dbd3d2a
@bembelimen
Add checkin to the dropdown
d08618c
@bembelimen
Merge branch '4.0-dev' of github.com:joomla/joomla-cms into workflow-…
5dc0353 
…article-buttons
@bembelimen
Add activate/deactivate JS for buttons
aa6d678
@bembelimen
Add click events for deactivated elements
4dcb6f5
@bembelimen
tabs => spaces
805237f
@bembelimen
Add publish method with workflow behavior
aacb27f
@chmst
Copy link
Copy Markdown
Contributor

chmst commented Nov 15, 2018

I have tested this item ✅ successfully on aacb27f

I have tested this item successfully on the latest v4.0. dev. (After npm install).
With different combinations and different workflows - also featured and non-featured and checke_out articles. Everything works as expected and really like this.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22393.

@fancyFranci
Copy link
Copy Markdown
Contributor

fancyFranci commented Nov 28, 2018

I have tested this item ✅ successfully on aacb27f

Tested with different stages and transitions and the patch worked as expected, with some grey status and helpful messages.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22393.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Nov 28, 2018

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22393.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 28, 2018
@wilsonge wilsonge merged commit 0467e65 into joomla:4.0-dev Dec 25, 2018
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 25, 2018
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Dec 25, 2018

Thanks

@bembelimen
Copy link
Copy Markdown
Contributor Author

bembelimen commented Dec 26, 2018

Thanks @wilsonge now we need this PR reopened to remove the unnecessary trash button: #21532

@bembelimen bembelimen deleted the workflow-article-buttons branch December 26, 2018 10:10
This was referenced Dec 26, 2018
Merged
Merged
@zero-24 zero-24 added this to the Joomla 4.0 milestone Dec 26, 2018
This was referenced Dec 28, 2018
Merged
Merged
Merged
Merged
This was referenced Dec 28, 2018
Merged
Merged
Merged
Merged
@bembelimen bembelimen mentioned this pull request Jan 6, 2019
Merged
This was referenced Jan 20, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quy Quy Quy left review comments

+5 more reviewers

@infograf768 infograf768 infograf768 left review comments

@C-Lodder C-Lodder C-Lodder left review comments

@ggppdk ggppdk ggppdk left review comments

@houndci-bot houndci-bot houndci-bot left review comments

@brianteeman brianteeman brianteeman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Language Change This is for Translators

Projects

None yet

Milestone

Joomla 4.0

Development

Successfully merging this pull request may close these issues.