Skip to content

Remove trash button from article toolbar#21532

Merged
wilsonge merged 7 commits intojoomla:4.0-devfrom
bembelimen:workflow-remove-trash-button-on-article
Dec 29, 2018
Merged

Remove trash button from article toolbar#21532
wilsonge merged 7 commits intojoomla:4.0-devfrom
bembelimen:workflow-remove-trash-button-on-article

Conversation

@bembelimen
Copy link
Copy Markdown
Contributor

@bembelimen bembelimen commented Aug 10, 2018

Pull Request for Issue #21527 .

Summary of Changes

As with the workflow, there is no direct trash function anymore but the trash transition will be defined with a workflow itself.

Testing Instructions

Look into the article list (backend)

Expected result

No trash button anymore

Actual result

Trashbutton without functionality

@brianteeman
Copy link
Copy Markdown
Contributor

NO NO NO - this is not a fix

@brianteeman
Copy link
Copy Markdown
Contributor

Seriously of you think that removing the delete button is the solution then I really give up.

@brianteeman
Copy link
Copy Markdown
Contributor

This solution is as sensible as me doing a pull request to remove workflows as the way to solve all the issues with it.

@bembelimen
Copy link
Copy Markdown
Contributor Author

As there is no "trash" state anymore, that is indeed the solution, because the article have to follow the execution flow, no direct jump (same for published/unpublished)

@brianteeman
Copy link
Copy Markdown
Contributor

Congratulations then on breaking every component in joomla

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Aug 11, 2018

@bembelimen

We can evidently trash ONE article at a time via the status of the article itself, but we can't trash anymore multiple articles at the same time, which indeed is not acceptable.

Same for other states...

@bembelimen
Copy link
Copy Markdown
Contributor Author

@infograf768 as I said above, there is absolutly no sense in having a "publish", "unpublish" or "trash" button anymore, because you (as "the user") have to follow the workflow sequence and there are a lot of scenarios, where the article in the current status has no publish/unpublish/trash route at the moment. Or you have multiple trash opportunities at the same time, so that makes the trash button useless again.

But: if you (as "the user" again) want to skip the sequence and trash multiple articles as "batch", then you can now use the batch functionallity. There is a new option for batching multiple articles with a new state.

@brianteeman
Copy link
Copy Markdown
Contributor

This is just plain wrong. No other way to put it. In fact even with this stupid and broken workflow code one can still have a delete button. You chose to reSolve the issue by simply deleting the button instead of adopting the sensible solution of checking the workflow to see if the user is able to delete something and then deciding to display the button or not.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Aug 11, 2018

Let's look at another scenario. Almost every component that exists in the joomlasphere has delete, publish and unpublished buttons in the toolbar. Unless they rewrite their code to use your workflow code they will all have those buttons. So after 15 years of an expected button that no one has ever suggested changing you are removing it, without consultation, discussion or testing just because it was easier for you to delete it than to fix it.

@infograf768
Copy link
Copy Markdown
Member

Also, if we keep workflow in core, there will be —I hope— a way to disable it completely, which means that the toolbar buttons should remain in that case.

@bembelimen
Copy link
Copy Markdown
Contributor Author

The trash button is still unnecessary at this position, because it's now in the dropdown menu. So the button can still be removed with this PR.

@infograf768
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 5e51aec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21532.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Dec 26, 2018

so how do you trash multiple articles at once and how do you address the UI issue where every other list view has a trash button but com_content does not

@bembelimen
Copy link
Copy Markdown
Contributor Author

bembelimen commented Dec 26, 2018

Why does com_content have no trash button?
This PR just removed the non-working button...

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Dec 26, 2018

so how do you trash multiple articles at once

Select articles, click on Change Status TOOLBAR button and select Trash

@infograf768
Copy link
Copy Markdown
Member

@wilsonge
I guess this can go in.

@wilsonge wilsonge merged commit 5c0b3e7 into joomla:4.0-dev Dec 29, 2018
@wilsonge wilsonge added this to the Joomla 4.0 milestone Dec 29, 2018
@bembelimen bembelimen deleted the workflow-remove-trash-button-on-article branch July 15, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants