Custom field "list of images" doesn't show directories properly#20294
Merged
rdeutz merged 4 commits intojoomla:stagingfrom Feb 3, 2020
Merged
Custom field "list of images" doesn't show directories properly#20294rdeutz merged 4 commits intojoomla:stagingfrom
rdeutz merged 4 commits intojoomla:stagingfrom
Conversation
Contributor
|
@eshiol Maybe add trim? |
laoneo
reviewed
May 7, 2018
| $path = $this->directory; | ||
|
|
||
| if (!is_dir($path)) | ||
| if (!is_dir($path) || is_dir(JPATH_ROOT . '/' . $path)) |
Member
There was a problem hiding this comment.
We should return when if (!is_dir($path) && !is_dir(JPATH_ROOT . '/' . $path)) and not let it through as JFolder::folders will then return false anyway.
Contributor
Return if (!is_dir($path) && !is_dir(JPATH_ROOT . '/' . $path))
Contributor
|
I have tested this item ✅ successfully on 15bc344 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20294. |
Contributor
|
The patch can't be applied. The file marked for modification does not exist: libraries/joomla/form/fields/folderlist.php This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20294. |
Contributor
|
@anibalsanchez again this is a Pull Request for staging not joomla 4 |
Member
|
I have tested this item ✅ successfully on 46b13ac This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20294. |
Member
|
@viocassel Please test latest version of PR. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20294. |
Contributor
|
I have tested this item ✅ successfully on 46b13ac This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20294. |
Contributor
|
@jwaisner Done 🤘 |
laoneo
reviewed
Jan 14, 2020
| $options = array(); | ||
|
|
||
| $path = $this->directory; | ||
| $path = ltrim($this->directory, '/'); |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20294. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #16708. replace PR #17125
Summary of Changes
This patch fixes JFormFieldFolderList. See: #16708
Testing Instructions
#16708 This patch should fix this behavior
Expected result
Field "list of images" works correctly.