This would always set the path to the root and not respect the configruation.

This sets the path to the directory passed via configuration starting from the root directory.

$path = $this->directory;
$path = JPATH_ROOT . '/' . $path;

Ah looks like i have not looked close enough.

Can you please include a issue description + test instructions?

I wrote a test component called com_pr17152
com_pr17125-3.7.3.3.zip
It creates a folder called "this is the right folder" in the folder components/com_pr17125 and a folder called "this is the wrong folder" in the folder administrator/components/com_pr17125.
In the configuration page you can choose the folder using a folder list field
<field name="file_path" type="folderlist" directory="components/com_pr17125" hide_none="true" hide_default="true" recursive="false" label="folder" description=""/>

Steps to reproduce the issue

Install the component com_pr17125
Go to Components > PR# 17125 > TEST

Expected result

The field should show the contents of the folder components/com_pr17125

Actual result

The field shows the contents of the folder administrator/components/com_pr17125

Testing Instructions

Install the patch PR# 17125
Go to Components > PR# 17125 > TEST

@eshiol can you please update Test Instructions in first Comment?

@laoneo Would this be a valid fix to always look in the root directory for images? Currently, it is relative so if there is an images in administrator, then it will look there and not in the root.

Not in the folderlist field, otherwise we would have here a BC break. If you need that case, then I would do your own form field for the imegelist custom field.

@laoneo Please confirm to close this PR for a different solution.

@Quy if the author is willing to implement a form field for the image list custom field in this pr then we can work it out here. Otherwise it should be closed.

Why we have a BC break can be reproduced with the following steps:

• Add the following code to the file administrator/components/com_content/config.xml after line 7
  <field name="file_path" type="folderlist" directory="help" hide_none="true" hide_default="true" recursive="false" label="Help" description=""/>
• Open the Article Manager options

Actual result

The en-GB folder is shown:

Result with patch

Warning and the select box is empty

I'm not be able to change the code. I lost the branch.
This code should solve the BC break

		if (!is_dir($path) || is_dir(JPATH_ROOT . '/' . $path))
		{
			$path = JPATH_ROOT . '/' . $path;
		}

By removing is_dir($path) the behavior will change slightly but the function still works

		if (is_dir(JPATH_ROOT . '/' . $path))
		{
			$path = JPATH_ROOT . '/' . $path;
		}

If the path doesn't exist, in the first case the error is related to JPATH_ROOT . '/' . $path, as it is now;

in the second one, the error is related to $path

@eshiol I am sorry if this is not the right way. I would close this PR and submit a new PR with the latest changes.

replaced by #20294