Revert #19977: Plugins field behavior#20293
Merged
HLeithner merged 5 commits intojoomla:stagingfrom May 14, 2019
SharkyKZ:Plugins_field_1
Merged
Revert #19977: Plugins field behavior#20293HLeithner merged 5 commits intojoomla:stagingfrom SharkyKZ:Plugins_field_1
HLeithner merged 5 commits intojoomla:stagingfrom
SharkyKZ:Plugins_field_1
Conversation
added 2 commits
April 27, 2018 18:30
Contributor
|
Cc @tonypartridge so the original author is aware ;-) |
Contributor
|
I have tested this item ✅ successfully on 929f46f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20293. |
Contributor
|
don' t hate me but yet another one for you @HLeithner |
Contributor
|
I have tested this item ✅ successfully on bb57a75 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20293. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20293. |
Member
|
thx |
tecpromotion
pushed a commit
to tecpromotion/joomla-cms
that referenced
this pull request
May 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
PR #19977 wasn't tested properly. As a result, it introduced unwanted behavior when saving form. The change prevents default value from being saved when it is set as a custom option in XML form.
Additionally, it adds check for a hardcoded language constant. This is not correct because the constant is added through custom option in XML form and could be anything.
Testing Instructions
Enable a Captcha plugin (e.g. reCaptcha).
Select the plugin as default Captcha plugin in Global Configuration and save.
Disable the plugin.
Go to Global Configuration and save again.
a) Open username reminder or password reset page
b) Check Captcha setting value (either in configuration.php or through JFactory::getApplication()->get('captcha')).
Expected result
a) No traces of captcha.
b)
0Actual result
a) Captcha label shown in form, indicating that Captcha plugin is set in configuration.
b)
recaptchaDocumentation Changes Required
No.