Make squeezebox initialize itself when a new subform row is added#20232
Merged
HLeithner merged 1 commit intojoomla:stagingfrom May 15, 2019
Merged
Make squeezebox initialize itself when a new subform row is added#20232HLeithner merged 1 commit intojoomla:stagingfrom
HLeithner merged 1 commit intojoomla:stagingfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 41229fd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20232. |
Contributor
|
I have tested this item ✅ successfully on 41229fd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20232. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20232. |
Contributor
|
@HLeithner please a final response 1 year old rtc pr |
41229fd to
e9e5e92
Compare
e9e5e92 to
8cfc9a9
Compare
Member
|
I think it makes no sense merging this if it fix nothing and subforms doesn't exists anylonger in j4. ymmv |
Contributor
Author
|
Wait... subforms don't exist anymore? |
Member
|
They are getting hopefully replaced with #24711 if you can please test subfields, also a migration script should kick in converting subforms to subfields. |
Contributor
|
@HLeithner you're getting confused here. subforms do exist :) these are the xml attributes. subfields you're linking to are just subforms as a custom field |
Member
|
thx @wilsonge for correction |
Contributor
Author
|
So we're still doing this, right? |
Remove that responsibility from subform.
3d6e8a2 to
51c93d2
Compare
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20232. |
Member
|
thx |
tecpromotion
pushed a commit
to tecpromotion/joomla-cms
that referenced
this pull request
May 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Subform repeatable has a function
fixScriptswhich calls a few js initialization functions on a few of the field types that require it. There is a now a better way to handle that kind of thing by having any field that may need initialization listen for an event fired by subform repeatable. In this PR, I am transferring responsibility of one such initialization from subform repeatable to the correct field type itself.Note: this PR doesn't really fix anything. Fields that use squeezebox already work with repeatable subforms. This just does it in a somewhat better way.
Another note: Squeezebox uses mootools and is deprecated. Bootstrap modals are prefered. Still, as long as some fields use it, they should use it like this.
Testing Instructions
Set up a subform containing a field that uses squeezebox (for example
contenthistory). There's a subform in the redirect plugin that's simple to use for this purpose.Open up the form and create new rows. The field in each new row should function properly.
Expected result
Fields that use squeezebox function normally.
Actual result
Fields that use squeezebox function normally.
Documentation Changes Required
None