Skip to content

Make squeezebox initialize itself when a new subform row is added#20232

Merged
HLeithner merged 1 commit intojoomla:stagingfrom
okonomiyaki3000:fix-subform-squeezebox
May 15, 2019
Merged

Make squeezebox initialize itself when a new subform row is added#20232
HLeithner merged 1 commit intojoomla:stagingfrom
okonomiyaki3000:fix-subform-squeezebox

Conversation

@okonomiyaki3000
Copy link
Copy Markdown
Contributor

Pull Request for Issue # .

Summary of Changes

Subform repeatable has a function fixScripts which calls a few js initialization functions on a few of the field types that require it. There is a now a better way to handle that kind of thing by having any field that may need initialization listen for an event fired by subform repeatable. In this PR, I am transferring responsibility of one such initialization from subform repeatable to the correct field type itself.

Note: this PR doesn't really fix anything. Fields that use squeezebox already work with repeatable subforms. This just does it in a somewhat better way.

Another note: Squeezebox uses mootools and is deprecated. Bootstrap modals are prefered. Still, as long as some fields use it, they should use it like this.

Testing Instructions

Set up a subform containing a field that uses squeezebox (for example contenthistory). There's a subform in the redirect plugin that's simple to use for this purpose.

Open up the form and create new rows. The field in each new row should function properly.

Expected result

Fields that use squeezebox function normally.

Actual result

Fields that use squeezebox function normally.

Documentation Changes Required

None

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Apr 27, 2018

I have tested this item ✅ successfully on 41229fd

Tested with the Redirect plugin.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20232.

@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 41229fd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20232.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Feb 3, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20232.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 3, 2019
@ghost ghost added the J3 Issue label Apr 5, 2019
@ghost ghost removed the J3 Issue label Apr 19, 2019
@alikon
Copy link
Copy Markdown
Contributor

alikon commented May 2, 2019

@HLeithner please a final response

1 year old rtc pr

@HLeithner
Copy link
Copy Markdown
Member

I think it makes no sense merging this if it fix nothing and subforms doesn't exists anylonger in j4. ymmv

@HLeithner HLeithner closed this May 10, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 10, 2019
@okonomiyaki3000
Copy link
Copy Markdown
Contributor Author

Wait... subforms don't exist anymore?

@HLeithner
Copy link
Copy Markdown
Member

They are getting hopefully replaced with #24711 if you can please test subfields, also a migration script should kick in converting subforms to subfields.

@wilsonge
Copy link
Copy Markdown
Contributor

@HLeithner you're getting confused here. subforms do exist :) these are the xml attributes. subfields you're linking to are just subforms as a custom field

@wilsonge wilsonge reopened this May 14, 2019
@HLeithner
Copy link
Copy Markdown
Member

thx @wilsonge for correction

@okonomiyaki3000
Copy link
Copy Markdown
Contributor Author

So we're still doing this, right?

@okonomiyaki3000 okonomiyaki3000 force-pushed the fix-subform-squeezebox branch from 3d6e8a2 to 51c93d2 Compare May 15, 2019 00:05
@Quy
Copy link
Copy Markdown
Contributor

Quy commented May 15, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20232.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 15, 2019
@HLeithner HLeithner merged commit b12056e into joomla:staging May 15, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 15, 2019
@HLeithner HLeithner added this to the Joomla 3.9.7 milestone May 15, 2019
@HLeithner
Copy link
Copy Markdown
Member

thx

@okonomiyaki3000 okonomiyaki3000 deleted the fix-subform-squeezebox branch May 15, 2019 23:59
tecpromotion pushed a commit to tecpromotion/joomla-cms that referenced this pull request May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants