Make media field initialize itself when a new subform row is added#20230
Merged
HLeithner merged 2 commits intojoomla:stagingfrom May 10, 2019
Merged
Make media field initialize itself when a new subform row is added#20230HLeithner merged 2 commits intojoomla:stagingfrom
HLeithner merged 2 commits intojoomla:stagingfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 83f9b21 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20230. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 83f9b21 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20230. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20230. |
Contributor
|
@HLeithner please a final response 1 year old rtc pr |
Contributor
Author
|
OK, I'll get right on it |
83f9b21 to
3443507
Compare
wilsonge
approved these changes
May 7, 2019
Remove that responsibility from subform.
3443507 to
2fe1f06
Compare
Member
|
thx |
Contributor
Author
|
See also #20231 |
tecpromotion
pushed a commit
to tecpromotion/joomla-cms
that referenced
this pull request
May 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Subform repeatable has a function
fixScriptswhich calls a few js initialization functions on a few of the field types that require it. There is a now a better way to handle that kind of thing by having any field that may need initialization listen for an event fired by subform repeatable. In this PR, I am transferring responsibility of one such initialization from subform repeatable to the correct field type itself.Note: this PR doesn't really fix anything. the media field type already works with repeatable subforms. This just does it in a somewhat better way.
Testing Instructions
Set up a subform containing a media field. There's a subform in the redirect plugin that's simple to use for this purpose.
Open up the form and create new rows. The media field in each new row should function properly.
Expected result
Media field functions normally.
Actual result
Media field functions normally.
Documentation Changes Required
None