Merged
Conversation
The Link CSS Style field label should be Link Class. The field adds a class to the menu item link, the current label implies it is adding inline CSS. Updated the label and description as per @ciar4n request
Contributor
|
I have tested this item ✅ successfully on c00a60a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19143. |
1 similar comment
|
I have tested this item ✅ successfully on c00a60a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19143. |
|
Ready to Commit after two successful tests. |
viocassel
reviewed
Dec 23, 2017
| COM_MENUS_ITEM_FIELD_ALIAS_MENU_LABEL="Menu Item" | ||
| COM_MENUS_ITEM_FIELD_ANCHOR_CSS_DESC="An optional, custom style to apply to the menu hyperlink." | ||
| COM_MENUS_ITEM_FIELD_ANCHOR_CSS_LABEL="Link CSS Style" | ||
| COM_MENUS_ITEM_FIELD_ANCHOR_CSS_DESC="An optional class to apply to the menu hyperlink." |
Contributor
There was a problem hiding this comment.
COM_MENUS_ITEM_FIELD_ANCHOR_CSS_DESC="An optional CSS class to apply to the menu hyperlink."
I think it will be more understandable 😉
Contributor
Author
There was a problem hiding this comment.
As pointed out by @ciar4n in the original issue it could be JavaScript.
Contributor
Author
|
Thanks |
photodude
pushed a commit
to photodude/joomla-cms
that referenced
this pull request
Dec 25, 2017
The Link CSS Style field label should be Link Class. The field adds a class to the menu item link, the current label implies it is adding inline CSS. Updated the label and description as per @ciar4n request
zero-24
added a commit
to zero-24/joomla
that referenced
this pull request
Jan 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Link CSS Style field label should be Link Class. The field adds a class to the menu item link, the current label implies it is adding inline CSS.
Updated the label and description as per @ciar4n request
Pull Request for Issue #19122