Add mandatory fourth argument for content events in com_media#17133
Merged
HLeithner merged 1 commit intojoomla:stagingfrom May 12, 2019
n9iels:to-few-arguments-mediamanger
Merged
Add mandatory fourth argument for content events in com_media#17133HLeithner merged 1 commit intojoomla:stagingfrom n9iels:to-few-arguments-mediamanger
HLeithner merged 1 commit intojoomla:stagingfrom
n9iels:to-few-arguments-mediamanger
Conversation
…ntentAfterDisplay events
|
Status is set on "Needs Review". |
mbabker
approved these changes
Jul 21, 2018
Contributor
|
Seriously, this is rather simple... |
Contributor
|
I have tested this item ✅ successfully on 614e122 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17133. |
Contributor
|
another task for @HLeithner |
Contributor
|
i was able to reproduce the error hacking the vote plugin as for test info |
Contributor
|
I have tested this item ✅ successfully on 614e122 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17133. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17133. |
Member
|
Thx |
tecpromotion
pushed a commit
to tecpromotion/joomla-cms
that referenced
this pull request
May 23, 2019
…ntentAfterDisplay events (joomla#17133)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #17129
Summary of Changes
This PR adds a fourth argument to the dispatcher for the
onContentBeforeDisplayandonContentAfterDisplayevents. Without this argument the following error might occur if there is no fallback for this argument:Testing Instructions
onContentBeforeDisplayplugin event without a fallback variable for the$pageparameter. Like this:You can also temporary remove the
= 0after the$pagefor a existing plugin. For example the vote plugin on this line: https://github.com/joomla/joomla-cms/blob/staging/plugins/content/vote/vote.php#L622. Set the error reporting to
maximum3. Go to the media manager and notice the following error: