[4.0-dev] Add userAgent check#16538
Merged
wilsonge merged 10 commits intojoomla:4.0-devfrom Jul 29, 2017
Merged
Conversation
Contributor
|
Thanks! |
cyrez
added a commit
to cyrez/http
that referenced
this pull request
Jan 30, 2026
…http package. Set default userAgent if nothing else is set, as it is in Joomla CMS http package. The change introduces in joomla/joomla-cms#45751 to replace CMS Http package by the framework package with the PSR-7 interface has some difference. The missing part to set userAgent as default if nothing else set will return a 403 error when trying to update an extension, if the update xml file is hosted on a server using a firewall. This missing part (difference with CMS http package) in Joomla 6.0+ blocked updates for one of my update server xml hosted on OVH where their firewall was enabled. Disabling the hosting server firewall was the only way to make the update process works. The userAgent check was introduced in this PR: joomla/joomla-cms#16538
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #16172
Summary of Changes
Set default useragent on all JHttpFactory calls #16172
Testing Instructions
Do a call with JHttpFactory and confirm that the UserAgent is set.
Set a useragent & try again
Expected result
userAgent is set.
Actual result
userAgent is not set.
Documentation Changes Required
None