Fix for: Field subform (multiple) produces wrong id#16480
Merged
mbabker merged 2 commits intojoomla:stagingfrom Oct 15, 2017
Merged
Fix for: Field subform (multiple) produces wrong id#16480mbabker merged 2 commits intojoomla:stagingfrom
mbabker merged 2 commits intojoomla:stagingfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on bf44558 |
Collaborator
|
I have tested this item ✅ successfully on bf44558 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16480. |
|
RTC after two successful tests. |
degobbis
added a commit
to joomtools/plg_content_jtformulator
that referenced
this pull request
Oct 14, 2017
degobbis
added a commit
to joomtools/plg_content_jtformulator
that referenced
this pull request
Oct 16, 2017
* Update PHP-Version compatibility in composer.json * Bugfix for showon functionality * Refactor translation of values * Change Updateserver * Add render field for UiKit v2 * Add render form for UiKit v2 * Add support for subforms * Bugfix JS for multiple subform forms See joomla/joomla-cms#16480 * Add new Row to validation * Add CSS-Override for invalid fields * Remove obsolete files * Bugfix Updateserver * Add compatibility for Joomla! 3.8.x * Update call for showon JS * Add scroll to top on errormessages * Add layoutpath override for subforms * Extended FormField->getLayoutPaths() to get my own paths * Add UiKit layout to render joomla.form.field.subform.repeatable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #15187 .
Summary of Changes
The pull fix the way how the script calculate the id for a fields and it's labels.
Also now it should be more close to
JFormField::getIdresult.Testing Instructions
For test can use next XML (place it in some params form,eg in template or custom module):
Expected result
After add "new row", check the input/labels id, they should be similar to screenshot:
Actual result
ID of the labels is not fixed,
they contain
Xeg:..._subform__subformX_..Documentation Changes Required
none