[3.8] Restructure version constants#16169
Merged
wilsonge merged 14 commits intojoomla:stagingfrom Aug 7, 2017
mbabker:version-constants
Merged
[3.8] Restructure version constants#16169wilsonge merged 14 commits intojoomla:stagingfrom mbabker:version-constants
wilsonge merged 14 commits intojoomla:stagingfrom
mbabker:version-constants
Conversation
…o version-constants
Contributor
Author
|
FWIW the build script does run with this PR applied without warnings, so it is fixing a bug 😉 (granted, only 3 or 4 people might ever run into it) |
Contributor
|
just fyi @mbabker issue still exists in 3.7.3 php 7.1.5 but NOT in 7.0.19 NOTE: setting to -1 does resolve it ( instead of 256M ) but 1G does not. |
Contributor
Author
|
This isn't going to fix an error where the stack trace points to code in Akeeba Backup. Specifically, the only error it will actually fix is in our packaging script. Plus, this is a PR targeted for 3.8, not a 3.7 release. |
Contributor
Author
|
While this mostly fixes an issue with PHP 7.1 and our build script, it also affects outside API use, it'd be nice if folks could please review and test this. |
Contributor
|
I have tested this item ✅ successfully on 556fabb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16169. |
izharaazmi
added a commit
to izharaazmi/joomla-cms
that referenced
this pull request
Aug 9, 2017
* staging: (148 commits) Correcting non-escaped double quotes in en-GB.plg_sampledata_testing.ini (joomla#17455) Correct namespace reference (Fix joomla#17448) Correcting Jalali/Persian calendar popup (joomla#17432) Adding russian calendar language file (joomla#17443) Reset for dev Prepare 3.8 Beta release Fix covers tags Fix file paths Move library files to just libraries/src as it should be (joomla#17441) Add a default empty array for the session queue (joomla#16943) [3.8] Restructure version constants (joomla#16169) Adjusting copyright and versions and two remaining "sampledata" (joomla#17435) PHP 7.2 has branched, update Travis config to reflect PHP 7.2 count warning (joomla#16840) Enforce array for subform values (joomla#16733) System URL menu link (joomla#17419) Don't use array merge here. (joomla#17391) add the checked attribute (joomla#17336) [RFC] Mod sample data (joomla#7680) Rename Page to Menu Item (joomla#17409) ...
izharaazmi
added a commit
to izharaazmi/joomla-cms
that referenced
this pull request
Aug 9, 2017
* staging: (148 commits) Correcting non-escaped double quotes in en-GB.plg_sampledata_testing.ini (joomla#17455) Correct namespace reference (Fix joomla#17448) Correcting Jalali/Persian calendar popup (joomla#17432) Adding russian calendar language file (joomla#17443) Reset for dev Prepare 3.8 Beta release Fix covers tags Fix file paths Move library files to just libraries/src as it should be (joomla#17441) Add a default empty array for the session queue (joomla#16943) [3.8] Restructure version constants (joomla#16169) Adjusting copyright and versions and two remaining "sampledata" (joomla#17435) PHP 7.2 has branched, update Travis config to reflect PHP 7.2 count warning (joomla#16840) Enforce array for subform values (joomla#16733) System URL menu link (joomla#17419) Don't use array merge here. (joomla#17391) add the checked attribute (joomla#17336) [RFC] Mod sample data (joomla#7680) Rename Page to Menu Item (joomla#17409) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR splits up the information in our existing version constants so each value represents one segment of the version string and deprecates the constants which hold combined segments. This also deprecates the
BUILDconstant as we aren't using it at all.Testing Instructions
The CMS should function normally and all places working with version data through the functions on our version class should have no change.
Documentation Changes Required
Note the deprecated constants.
TODO