Skip to content

Fix double parameters creation for parameters of home template and of template override#12688

Merged
zero-24 merged 2 commits intojoomla:stagingfrom
ggppdk:patch-26
Nov 3, 2016
Merged

Fix double parameters creation for parameters of home template and of template override#12688
zero-24 merged 2 commits intojoomla:stagingfrom
ggppdk:patch-26

Conversation

@ggppdk
Copy link
Copy Markdown
Contributor

@ggppdk ggppdk commented Nov 1, 2016 •
edited by joomla-cms-bot
Loading

Pull Request for Issue #12651

Summary of Changes

The home template styles are cloned, inside the foreach loop (see the modified code) and then added to the same array: $templates

as $templates[0]

thus parameters creation for template home: $templates[0]
will happen twice

Testing Instructions

Styles are applied as configured

Documentation Changes Required

none

@ggppdk ggppdk mentioned this pull request Nov 1, 2016
Closed
@SharkyKZ
Copy link
Copy Markdown
Contributor

SharkyKZ commented Nov 2, 2016

Default template seems to work fine but setting template via URL does not, params are still missing.

@ggppdk
Copy link
Copy Markdown
Contributor Author

ggppdk commented Nov 2, 2016 •
edited
Loading

@SharkyKZ
Thanks, i have fixed that case too with last commt:

The array $templates, already has parameters created for all template
then we select just template override, there is no reason to try to create parameters again

@Espionage724 @csiteru
Please test

@SharkyKZ
Copy link
Copy Markdown
Contributor

SharkyKZ commented Nov 2, 2016

I have tested this item ✅ successfully on 5b4816f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12688.

@ggppdk ggppdk changed the title Fix double parameters creation for parameters of home style Fix double parameters creation for parameters of home template and of template override Nov 2, 2016
@csiteru
Copy link
Copy Markdown
Contributor

csiteru commented Nov 2, 2016

@ggppdk I have not changed with the latest madifications. All T3 templates have default settings...

@ggppdk
Copy link
Copy Markdown
Contributor Author

ggppdk commented Nov 2, 2016

@csiteru

They may have similar problem in their custom, myself i usually use 2 other template makers, but i think have a few from them too, if i get time i might test T3 template case

  • you may notify the template maker about the issue, and link to this discussion

@csiteru csiteru mentioned this pull request Nov 2, 2016
Open
@dgrammatiko
Copy link
Copy Markdown
Contributor

dgrammatiko commented Nov 3, 2016

I have tested this item ✅ successfully on 5b4816f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12688.

@jeckodevelopment
Copy link
Copy Markdown
Member

jeckodevelopment commented Nov 3, 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12688.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 3, 2016
@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Nov 3, 2016
@zero-24 zero-24 merged commit 35bfa3a into joomla:staging Nov 3, 2016
@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Nov 3, 2016

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 3, 2016
@csiteru
Copy link
Copy Markdown
Contributor

csiteru commented Nov 3, 2016

Hi!
I found the bug why the template style always is set default on my site on j3.6.4.
When SEF is off, in

joomla-cms/libraries/cms/application/site.php

Line 440 in 5b4816f

$item = $menu->getItem($this->input->getInt('Itemid', null));
is set right ItemId and template is set right. But is SEF is ON, This function returns 0 and $id set = 0 in line 448 ($id = $item->template_style_id). Thats why
$template = $templates[$id]; is always = 0, and template style set defaunt.

joomla-cms/libraries/cms/application/site.php

Line 506 in 5b4816f

$template = $templates[$id];

@ggppdk
Copy link
Copy Markdown
Contributor Author

ggppdk commented Nov 3, 2016

@csiteru
This is not directly related to what this PR fixes, you should open a new issue with a good description

@csiteru
Copy link
Copy Markdown
Contributor

csiteru commented Nov 3, 2016

@ggppdk
Unfortunately, I can explain only very badly in English =(
I'll try to make a video

@ggppdk ggppdk deleted the patch-26 branch November 3, 2016 20:28
@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Nov 3, 2016

Yes please open a new issue with that video than :)

@csiteru csiteru mentioned this pull request Nov 4, 2016
Closed
nvyush pushed a commit to nvyush/joomla-cms that referenced this pull request Nov 9, 2016
@ggppdk @nvyush
Fix double parameters creation for parameters of home template and of…
a281dd6 
… template override (joomla#12688)

* Fix double parameters creation for parameters of home style

* Fixed double creation of parameters for template override
@leetempest
Copy link
Copy Markdown

leetempest commented Nov 10, 2016

Does anyone have a fix when using a T3 template with two assigned styles running on 3.6.4? I have a logged in area I need to use a different template / menu system on but it is always displaying the default template when seo is turned on. Thanks

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Nov 10, 2016

I suggest that you contact t3 diectly as we can only support issues in the
Joomla core

On 10 November 2016 at 15:52, Lee Tempest notifications@github.com wrote:

Does anyone have a fix when using a T3 template with two assigned styles
running on 3.6.4? I have a logged in area I need to use a different
template / menu system on but it is always displaying the default template
when seo is turned on. Thanks

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12688 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8eNJbKKwHB_mx1wT-dWrN0gTTjPAks5q8y-qgaJpZM4Kmly9
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

@infograf768 infograf768 mentioned this pull request Jan 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 3.7.0

Development

Successfully merging this pull request may close these issues.

9 participants

@ggppdk @SharkyKZ @csiteru @dgrammatiko @jeckodevelopment @zero-24 @leetempest @brianteeman @joomla-cms-bot