[com_installer] Translate the extension name if possible#11595
Merged
wilsonge merged 5 commits intojoomla:stagingfrom Aug 15, 2016
Merged
[com_installer] Translate the extension name if possible#11595wilsonge merged 5 commits intojoomla:stagingfrom
wilsonge merged 5 commits intojoomla:stagingfrom
Conversation
Closed
Contributor
|
I have tested this item ✅ successfully on 44f1ae2 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11595. |
Member
|
I have tested this item ✅ successfully on 44f1ae2 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11595. |
Contributor
Author
|
@mbabker do you remember a reason for this |
Contributor
Contributor
Author
|
Thanks. If that gots accepted i can move the names to the language files. |
Contributor
|
Setting RTC as we have two good tests. The count was just reset by the merge update This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11595. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11595. |
|
I have tested this item ✅ successfully on 19e8832 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11595. |
Contributor
Author
Done #11626 |
ggppdk
pushed a commit
to ggppdk/joomla-cms
that referenced
this pull request
Aug 19, 2016
roland-d
pushed a commit
to roland-d/joomla-cms
that referenced
this pull request
Sep 11, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #11567
Summary of Changes
Allow all kind of extensions to have translatable names
Testing Instructions
LibraryLIB_JOOMLA_XML_DESCRIPTION{"name":"LIB_JOOMLA_XML_DESCRIPTION","type":"library","creationDate":"2008","author":"Joomla! Project","copyright":"Copyright (C) 2005 - 2016 Open Source Matters. All rights reserved.","authorEmail":"admin@joomla.org","authorUrl":"https:\/\/www.joomla.org","version":"13.1","description":"LIB_JOOMLA_XML_DESCRIPTION","group":"","filename":"joomla"}Documentation Changes Required
Nothing as this is the same as all other extensions.