Skip to content

[com_installer] Translate the extension name if possible#11595

Merged
wilsonge merged 5 commits intojoomla:stagingfrom
zero-24:installerManage
Aug 15, 2016
Merged

[com_installer] Translate the extension name if possible#11595
wilsonge merged 5 commits intojoomla:stagingfrom
zero-24:installerManage

Conversation

@zero-24
Copy link
Copy Markdown
Contributor

@zero-24 zero-24 commented Aug 14, 2016

Pull Request for Issue #11567

Summary of Changes

Allow all kind of extensions to have translatable names

Testing Instructions

  • go to com_installer -> manage -> manage
  • select the type Library
  • see all items are translated (no language string)
  • go to the database and edit the entry for the Joomla Lib
  • set the name (collum params) to LIB_JOOMLA_XML_DESCRIPTION

{"name":"LIB_JOOMLA_XML_DESCRIPTION","type":"library","creationDate":"2008","author":"Joomla! Project","copyright":"Copyright (C) 2005 - 2016 Open Source Matters. All rights reserved.","authorEmail":"admin@joomla.org","authorUrl":"https:\/\/www.joomla.org","version":"13.1","description":"LIB_JOOMLA_XML_DESCRIPTION","group":"","filename":"joomla"}

  • go to com_installer -> manage -> manage again
  • see it is not translated
  • apply this PR
  • see it is translated.

Documentation Changes Required

Nothing as this is the same as all other extensions.

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 44f1ae2

Followed test instructions - all good


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11595.

@jeckodevelopment
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 44f1ae2


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11595.

@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Aug 14, 2016

@mbabker do you remember a reason for this conditional in the first place?

@mbabker
Copy link
Copy Markdown
Contributor

mbabker commented Aug 14, 2016

879de61

@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Aug 14, 2016

Thanks. If that gots accepted i can move the names to the language files.

@brianteeman
Copy link
Copy Markdown
Contributor

Setting RTC as we have two good tests. The count was just reset by the merge update


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11595.

@brianteeman
Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11595.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 14, 2016
@truptikagathara
Copy link
Copy Markdown

I have tested this item ✅ successfully on 19e8832


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11595.

@wilsonge wilsonge merged commit 92a0940 into joomla:staging Aug 15, 2016
@wilsonge wilsonge added this to the Joomla 3.6.3 milestone Aug 15, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 15, 2016
@zero-24 zero-24 deleted the installerManage branch August 15, 2016 22:51
@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Aug 15, 2016

Thanks. If that gots accepted i can move the names to the language files.

Done #11626

ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request Aug 19, 2016
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants