Skip to content

Allow also viewable ordering fields#11572

Merged
wilsonge merged 1 commit intojoomla:stagingfrom
rdeutz:fix_regression_for_fof_sorting
Aug 13, 2016
Merged

Allow also viewable ordering fields#11572
wilsonge merged 1 commit intojoomla:stagingfrom
rdeutz:fix_regression_for_fof_sorting

Conversation

@rdeutz
Copy link
Copy Markdown
Contributor

@rdeutz rdeutz commented Aug 12, 2016

Summary of Changes

A combination of two PRs #7368 and the commit for #5731 broke the ability to have visible ordering fields. This PR will fix the problem.

Testinstructions

  • Install a fof component with visible ordering fields (I have used admin-tools-pro, URL-Redirection) add some items and try to order with drag/drop and with changing the number in the field. This should fail.
  • Apply patch
  • Try it again and it should now work.
  • Test also ordering in the article manager and category manager

@rdeutz
Copy link
Copy Markdown
Contributor Author

rdeutz commented Aug 12, 2016

Original fix was here #11571 this is a redo with testing instructions and without swearing.

@ggppdk
Copy link
Copy Markdown
Contributor

ggppdk commented Aug 12, 2016

To test

  • with making the ordering inputs visible (and thus editable too)

Joomla backend articles manager,
featured manager,
and category manager

  • Edit "styles" of isis template add file css/custom.css with:
.text-area-order, .sortable-handler + input {
  display: inline !important;
  width: 40px; text-align: right;
}
  1. In e.g. feature manager make hard refresh to get new JS loaded and sort by the ordering the column
  2. E.g. i have 10 records, manually (typing) reverse the last 4 items e.g. 7 - 8 - 9 - 10 to 10 - 9 - 8 - 7
  3. Drag and drop some of the records at the top, this will trigger an AJAX save too, like you clicked a save button, thus your manual ordering will get saved too
  4. DO a CTRL-F5 or similar refresh

Also if you want to add save button to the header of the column of e.g. featured manager
After:

<?php echo JHtml::_('searchtools.sort', '', 'fp.ordering', $listDirn ...

Add:

<?php echo JHTML::_('grid.order', $this->items, 'filesave.png', 'featured.saveorder' ); ?>

@ggppdk
Copy link
Copy Markdown
Contributor

ggppdk commented Aug 12, 2016

I have tested this item ✅ successfully on 40795cc

Tested

  • articles manager
  • featured mananager
  • category manager

drag and drop works

also about manual editing ordering numbers, after you edit some of them and:

  • either drag and drop some other row (to trigger save)
  • or if you have a save button visible and you click

then the ordering is saved good in this case too


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11572.

@ggppdk
Copy link
Copy Markdown
Contributor

ggppdk commented Aug 12, 2016

Also i forgot to mention

  • removing the CSS that i used above to make the fields visible (thus default Joomla styling to have them hidden)

then re-ordering works in this case too for the 3 managers, and also tested menu manager

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 40795cc

tested with admintools


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11572.

@wilsonge
Copy link
Copy Markdown
Contributor

2 good tests. Merging

@wilsonge wilsonge merged commit 97012a0 into joomla:staging Aug 13, 2016
@rdeutz rdeutz added this to the Joomla 3.6.3 milestone Aug 13, 2016
@truptikagathara
Copy link
Copy Markdown

I have tested this item ✅ successfully on 40795cc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11572.

@rdeutz rdeutz deleted the fix_regression_for_fof_sorting branch September 6, 2016 12:49
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants