Improve JHtmlNumber::bytes by izharaazmi · Pull Request #11026 · joomla/joomla-cms

izharaazmi · 2016-07-05T12:43:04Z

Summary of Changes

Allow parsing of input in suffixed format such as "128M", "1.2G", "340K", "1234.56 MB" for conversion.
Allow returning number of bytes without any unit suffix
Added support for suffixes EB, ZB, YB.

Testing Instructions

Apparently no straight-forward way to test within Joomla. Please write some code that uses the method JHtmlNumber::bytes()

A sample code is given below (Seeds are taken from Unit Test, you may want to use your own test data):

echo JHtml::_('number.bytes', 1, 'auto'). "\n";
echo JHtml::_('number.bytes', 1024, 'auto'). "\n";
echo JHtml::_('number.bytes', 1024 * 1024, 'auto'). "\n";
echo JHtml::_('number.bytes', 1024 * 1024 * 1024, 'auto'). "\n";
echo JHtml::_('number.bytes', 1024 * 1024 * 1024 * 1024, 'auto'). "\n";
echo JHtml::_('number.bytes', 1024 * 1024 * 1024 * 1024 * 1024, 'auto'). "\n";
echo JHtml::_('number.bytes', 0, 'auto'). "\n";
echo JHtml::_('number.bytes', 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024, 'auto'). "\n";
echo JHtml::_('number.bytes', 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024, 'YB'). "\n";
echo JHtml::_('number.bytes', 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024, 'ZB'). "\n";
echo JHtml::_('number.bytes', 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024, 'EB'). "\n";
echo JHtml::_('number.bytes', 1024 * 1024 * 1024 * 1024 * 1024, 'PB'). "\n";
echo JHtml::_('number.bytes', 1024 * 1024 * 1024 * 1024 * 1024, 'TB'). "\n";
echo JHtml::_('number.bytes', 1024 * 1024 * 1024 * 1024 * 1024, 'GB'). "\n";
echo JHtml::_('number.bytes', 1024 * 1024 * 1024 * 1024 * 1024, 'MB'). "\n";
echo JHtml::_('number.bytes', 1024 * 1024 * 1024 * 1024 * 1024, 'kB'). "\n";
echo JHtml::_('number.bytes', 1024 * 1024 * 1024 * 1024 * 1024, 'b'). "\n";
echo JHtml::_('number.bytes', 1024 * 1024 * 1024 * 1024 * 1024, ''). "\n";
echo JHtml::_('number.bytes', 1357, 'auto'). "\n";
echo JHtml::_('number.bytes', 1357, 'auto', 1). "\n";
echo JHtml::_('number.bytes', 1357, 'auto', 2). "\n";
echo JHtml::_('number.bytes', 1357, 'auto', 3). "\n";
echo JHtml::_('number.bytes', 1357, 'auto', 4). "\n";
echo JHtml::_('number.bytes', '1024K', 'auto'). "\n";
echo JHtml::_('number.bytes', '1 GB', 'MB'). "\n";
echo JHtml::_('number.bytes', '1.0752E+4 MB', 'GB'). "\n";

Expect the following output from above:

1 b
1 kB
1 MB
1 GB
1 TB
1 PB
0
1 YB
1 YB
1024 ZB
1048576 EB
1 PB
1024 TB
1048576 GB
1073741824 MB
1099511627776 kB
1.1258999068426E+15 b
1.1258999068426E+15
1.33 kB
1.3 kB
1.33 kB
1.325 kB
1.3252 kB
1 MB
1024 MB
10.5 GB

PS: There is probably a B/C break due to 'kb' changed to 'kB'. Please advise if that needs to be addressed.

Allow parsing of input in suffixed format such as "128M", "1.2G", "340K", "1234.56 MB" for conversion. Allow returning number of bytes without any unit suffix Added support for suffixes EB, ZB, YB. No B/C break hopefully.

…nce this is a JHtml method and not a conversion function we probably can afford little loss of significance.

pritalpatel · 2016-07-18T12:55:28Z

I have tested this item ✅ successfully on 3870104

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11026.}

pritalpatel · 2016-07-18T13:02:09Z

I have apply this sample code in my joomla-cms/components/com_content/views/article/tmpl/default.php file and see the result. It's works successfully.

Thanks.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11026.}

ghost · 2016-07-23T11:21:54Z

I have tested this item ✅ successfully on 3870104

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11026.}

brianteeman · 2016-07-23T11:23:49Z

RTC - thanks

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11026.}

* Improve JHtmlNumber::bytes Allow parsing of input in suffixed format such as "128M", "1.2G", "340K", "1234.56 MB" for conversion. Allow returning number of bytes without any unit suffix Added support for suffixes EB, ZB, YB. No B/C break hopefully. * Fix unit test failure, the failure is due to float comparison, but since this is a JHtml method and not a conversion function we probably can afford little loss of significance.

HLeithner · 2016-08-25T13:56:11Z

Dump question but shouldn't it be KiB, MiB, and so on to reflect the correct SI Binary prefix?

brianteeman · 2016-08-25T14:07:30Z

@HLeithner not a dumb question but its not standard behaviour to use SI for this

HLeithner · 2016-08-25T14:13:51Z

@brianteeman that depends ;-) The ISO/IEC 80000-13:2008 tells us that the standard is to use it ;-)

I know that most people don't use it, I don't use it always but try to. But thats not the point. The question is should Joomla should use the/a "official standard"

brianteeman · 2016-08-25T14:15:31Z

No we have to use the "real world standard"

izharaazmi · 2016-08-25T14:28:46Z

I agree with @brianteeman on this. However, we can add another method in the same class that is IEC aware or simply add another parameter to the same method like $iec = false

HLeithner · 2016-08-25T15:32:09Z

@izharaazmi sounds good
@brianteeman I like that ;-) and just wanted to notice.

brianteeman · 2016-08-25T15:33:51Z

Please no more options

zero-24 · 2016-08-25T15:40:25Z

i gues @izharaazmi means on code not in the UI 😄

brianteeman · 2016-08-25T15:43:15Z

No point having an option in the code if you have to hack the core to use it ;)

mbabker · 2016-08-25T15:45:28Z

No point having an option in the code if you have to hack the core to use it

That's exactly what parameters on method calls are for. Not every option has to be something managed via the UI, it could be an option used by developers in their code to change a behavior.

HLeithner · 2016-08-25T16:11:56Z

In this case it would be even better to have a option in the ui to switch the complete site from one version to the other and not only a part of the site ;-)

izharaazmi · 2016-08-26T07:49:33Z

I have added the support for IEC Binary prefixes. It is supposed to be fully B/C. Please test and review.

* Improve JHtmlNumber::bytes Allow parsing of input in suffixed format such as "128M", "1.2G", "340K", "1234.56 MB" for conversion. Allow returning number of bytes without any unit suffix Added support for suffixes EB, ZB, YB. No B/C break hopefully. * Fix unit test failure, the failure is due to float comparison, but since this is a JHtml method and not a conversion function we probably can afford little loss of significance.

…dency #11026) (#11255) * Show configured upload limit when uploading installer package. Otherwise when uploading a larger file than the configured limit, the page reloads without any information about what went wrong. * Reduce amount of information displayed. * Show upload limits for file input everywhere. Refactor the calculation part to JUtility class.

…. (Dependency #11026)"

…. (Dependency #11026)" (#12390)

Improve JHtmlNumber::bytes

dcd940f

Allow parsing of input in suffixed format such as "128M", "1.2G", "340K", "1234.56 MB" for conversion. Allow returning number of bytes without any unit suffix Added support for suffixes EB, ZB, YB. No B/C break hopefully.

joomla-cms-bot added PR-staging Unit/System Tests labels Jul 5, 2016

Fix unit test failure, the failure is due to float comparison, but si…

3870104

…nce this is a JHtml method and not a conversion function we probably can afford little loss of significance.

izharaazmi force-pushed the jhtml-number-bytes branch from ac35546 to 3870104 Compare July 5, 2016 13:18

izharaazmi mentioned this pull request Jul 23, 2016

Show configured upload limit when uploading installer package. (Dependency #11026) #11255

Merged

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 23, 2016

rdeutz merged commit 71c7651 into joomla:staging Aug 14, 2016

rdeutz added this to the Joomla 3.6.3 milestone Aug 14, 2016

brianteeman removed the RTC This Pull Request is Ready To Commit label Aug 18, 2016

izharaazmi deleted the jhtml-number-bytes branch August 23, 2016 06:23

izharaazmi mentioned this pull request Aug 26, 2016

Also allow use of IEC Binary prefix system for JHtmlNumber::bytes #11803

Merged

rdeutz added a commit that referenced this pull request Oct 11, 2016

Revert "Show configured upload limit when uploading installer package…

2e22d83

…. (Dependency #11026)"

rdeutz added a commit that referenced this pull request Oct 11, 2016

Revert "Show configured upload limit when uploading installer package…

b76410a

…. (Dependency #11026)" (#12390)

Uh oh!

Conversation

izharaazmi commented Jul 5, 2016 • edited by brianteeman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Uh oh!

pritalpatel commented Jul 18, 2016

Uh oh!

pritalpatel commented Jul 18, 2016

Uh oh!

ghost commented Jul 23, 2016

Uh oh!

brianteeman commented Jul 23, 2016

Uh oh!

HLeithner commented Aug 25, 2016

Uh oh!

brianteeman commented Aug 25, 2016

Uh oh!

HLeithner commented Aug 25, 2016

Uh oh!

brianteeman commented Aug 25, 2016

Uh oh!

izharaazmi commented Aug 25, 2016

Uh oh!

HLeithner commented Aug 25, 2016

Uh oh!

brianteeman commented Aug 25, 2016

Uh oh!

zero-24 commented Aug 25, 2016

Uh oh!

brianteeman commented Aug 25, 2016 via email

Uh oh!

mbabker commented Aug 25, 2016

Uh oh!

HLeithner commented Aug 25, 2016

Uh oh!

izharaazmi commented Aug 26, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

izharaazmi commented Jul 5, 2016 •

edited by brianteeman

Loading