Falling back to the Squiz version of the ScopeClosingBrace sniff.#4
Merged
eddieajau merged 1 commit intojoomla:masterfrom Oct 8, 2012
LouisLandry:brace-fix
Merged
Falling back to the Squiz version of the ScopeClosingBrace sniff.#4eddieajau merged 1 commit intojoomla:masterfrom LouisLandry:brace-fix
eddieajau merged 1 commit intojoomla:masterfrom
LouisLandry:brace-fix
Conversation
eddieajau
added a commit
that referenced
this pull request
Oct 8, 2012
Falling back to the Squiz version of the ScopeClosingBrace sniff.
jatitoam
pushed a commit
to jatitoam/coding-standards
that referenced
this pull request
May 19, 2018
v1.2 hotfix
wilsonge
pushed a commit
to wilsonge/coding-standards
that referenced
this pull request
Oct 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will remove the now unnecessary custom sniff class for ScopeClosingBrace. The Squiz version now adequately supports tabs instead of spaces, and has been updated for the latest versions of PHP_CodeSniffer. This drastically reduces the number of false positives we are seeing with the given sniff.