Closed
Conversation
b8685fc to
6855d4c
Compare
jonas
added a commit
that referenced
this pull request
May 21, 2018
jonas
added a commit
that referenced
this pull request
May 21, 2018
jonas
added a commit
that referenced
this pull request
May 21, 2018
rolandwalker
pushed a commit
to rolandwalker/tig
that referenced
this pull request
May 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #679, add
configure --with-icuto compile with support for libicu, and as an example, changecontains_uppercase()to Unicode-awarestring_contains_uppercase().The pros of libicu are that it is deep, complete, well-tested, and up-to-date.
The cons are that it contains multiple overlapping/conflicting APIs, and that UTF8 is generally treated as second-class compared to UTF16.
In the example function we are able to use one of the UTF8-specific APIs cleanly without recoding.
Linking with libpcre might also be required to get utf8-aware search. libicu knows about regular expressions but only exposes an interface for C++ and Java.