Skip to content

Fix reading the value of status.showUntrackedFiles#1211

Merged
koutcher merged 1 commit intojonas:masterfrom
storoj:patch-1
Jul 7, 2022
Merged

Fix reading the value of status.showUntrackedFiles#1211
koutcher merged 1 commit intojonas:masterfrom
storoj:patch-1

Conversation

@storoj
Copy link
Copy Markdown
Contributor

@storoj storoj commented Jul 6, 2022

It seems like git config --list prints everything in lowercase. That results in tig not recognising the value of status.showUntrackedFiles since it's being printed as status.showuntrackedfiles.

parse_bool(&opt_diff_noprefix, value);

else if (!strcmp(name, "status.showUntrackedFiles"))
else if (!strcmp(name, "status.showuntrackedfiles"))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix, thanks!
If possible, could you update the commit subject (the first line in the commit message) to mention status.showUntrackedFiles like the PR subject does? The commit subject will appear in the release notes (via git-shortlog).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

It seems like `git config --list` prints everything in lowercase. That results in `tig` not recognising the value of `status.showUntrackedFiles` since it's being printed as `status.showuntrackedfiles`.
@koutcher koutcher merged commit 96d7223 into jonas:master Jul 7, 2022
vxsl pushed a commit to vxsl/tig that referenced this pull request Mar 18, 2026
It seems like `git config --list` prints everything in lowercase. That results in `tig` not recognising the value of `status.showUntrackedFiles` since it's being printed as `status.showuntrackedfiles`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants