Fix navigation between chunks after splitting chunk#1162
Merged
koutcher merged 1 commit intojonas:masterfrom Jan 4, 2022
Merged
Fix navigation between chunks after splitting chunk#1162koutcher merged 1 commit intojonas:masterfrom
koutcher merged 1 commit intojonas:masterfrom
Conversation
krobelus
reviewed
Nov 27, 2021
src/stage.c
Outdated
| return REQ_NONE; | ||
| } | ||
| stage_split_chunk(view, line); | ||
| reset_search(view); |
Contributor
There was a problem hiding this comment.
Looks obviously correct. I guess we could do this on successful splits only, but I don't see a good reason to favor one over the other
diff --git a/src/stage.c b/src/stage.c
index 1b0a92e2..0e869381 100644
--- a/src/stage.c
+++ b/src/stage.c
@@ -404,6 +404,7 @@ stage_split_chunk(struct view *view, struct line *chunk_start)
if (chunks) {
stage_insert_chunk(view, &header, chunk_start, NULL, NULL);
redraw_view(view);
+ reset_search(view);
report("Split the chunk in %d", chunks + 1);
} else {
report("The chunk cannot be split");Also fix the color of the first split chunk. Closes jonas#1101
9b59fc9 to
45e9dfd
Compare
vxsl
pushed a commit
to vxsl/tig
that referenced
this pull request
Mar 18, 2026
Also fix the color of the first split chunk. Closes jonas#1101 Reviewed-by: Johannes Altmanninger <aclopte@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix the color of the first split chunk.
Closes #1101