updates to feat custom elements import dependencies#2
Merged
johnjenkins merged 13 commits intojohnjenkins:feat-custom-elements-import-dependenciesfrom Sep 14, 2021
rwaskiewicz:johnjenkins-feat-custom-elements-import-dependencies-ryan
Merged
updates to feat custom elements import dependencies#2johnjenkins merged 13 commits intojohnjenkins:feat-custom-elements-import-dependenciesfrom rwaskiewicz:johnjenkins-feat-custom-elements-import-dependencies-ryan
feat custom elements import dependencies#2johnjenkins merged 13 commits intojohnjenkins:feat-custom-elements-import-dependenciesfrom
rwaskiewicz:johnjenkins-feat-custom-elements-import-dependencies-ryan
Conversation
…ciljs#3046) this PR is the first step in trying to improve our automation in GitHub. it removes the 'Awaiting Reply' label and replaces it with the 'Reply Received' label when an individual replies to a GitHub issue via a comment. this PR also prevents issues that are tagged with 'Reply Received' from being culled by the stale issue configuration. this is a first step in improving our workflow. this PR does not cover every possibility/scenario for interacting with the community.
create the initial PR template for contributing to Stencil STENCIL-6: Add GH PR Template to Stencil Core
…iljs#3048) add documentation for smoke testing Stencil's browser API
- update the Stencil version textarea to be an input box, require it to be filled out - update the code reproduction url to be required
…#3047) patch textContent for scoped components that use slots. because there is no shadow dom, calling the setter/getter on `textContent` would otherwise act on the bare HTML elements. use the stencil metadata to relocate the text to the proper location this functionality is hidden behind a feature flag. users may enable it by setting `scopedSlotTextContentFix` to `true` in the `extras` section of their Stencil configuration file. This field defaults to `false` (keeping the same behavior that exists today) while this flag is evaluated. this does _not_ bring this functionality over to the custom elements build
create an adr discussing how/why the team shall adopt CommonMark as the standard for the docs-readme output target
…:johnjenkins/stencil into johnjenkins-feat-custom-elements-import-dependencies
fixes the scenario where the element tag name does not match the class name after being transformed to PascalCase. Rely on the component class name
johnjenkins
approved these changes
Sep 14, 2021
johnjenkins
approved these changes
Sep 14, 2021
5591f4f
into
johnjenkins:feat-custom-elements-import-dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 This is the PR I mentioned earlier in Slack about minor fixups/changes. The last 5 commits are the ones with actual changes in them (the ones prior to that I think are there as an artifact of the target branch not having them yet). Starting with b1017f0, I added a small comment to each explaining what they did if the git commit message didn't explain it fully.
There's one more bug regarding output getting split into 2 separate files I'm still chasing down, but I figure it's better to share progress now