Skip to content

chore(github): refine bug report template#3053

Merged
rwaskiewicz merged 1 commit intomasterfrom
rwaskiewicz/update-bug-report-template
Sep 8, 2021
Merged

chore(github): refine bug report template#3053
rwaskiewicz merged 1 commit intomasterfrom
rwaskiewicz/update-bug-report-template

Conversation

@rwaskiewicz
Copy link
Copy Markdown
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Unit tests (npm test) were run locally and passed
  • E2E Tests (npm run test.karma.prod) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): GitHub Issue Changes

What is the current behavior?

  • the Stencil version is a textarea (which is probably too big) and not required to be filled out
  • the code reproduction url is not required to be filled out

GitHub Issue Number: N/A

What is the new behavior?

  • update the Stencil version textarea to be an input box, require it to be filled out
  • update the code reproduction url to be required
    • this might be too aggressive, LMK what you think

Does this introduce a breaking change?

  • Yes
  • No

Testing

None, I don't think there's a good way to test this

Other information

Link to the GH Docs for Syntax: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema#input

- update the Stencil version textarea to be an input box, require it to be filled out
- update the code reproduction url to be required
@rwaskiewicz rwaskiewicz requested a review from a team September 8, 2021 12:14
Copy link
Copy Markdown
Contributor

@splitinfinities splitinfinities left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see it

@rwaskiewicz rwaskiewicz merged commit b45e96d into master Sep 8, 2021
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz/update-bug-report-template branch September 8, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants