perf: skip heavy resource webpack stats#164
Merged
chrisblossom merged 1 commit intojohnagan:masterfrom Oct 15, 2019
Merged
Conversation
Collaborator
|
This looks great. Thanks for the contribution! @johnagan could we get a release at your earliest convenience? |
SmushyTaco
pushed a commit
to SmushyTaco/clean-webpack-plugin
that referenced
this pull request
Jan 15, 2025
perf: skip heavy resource webpack stats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since we only need assets from webpack stats.toJson(), we can pass 'forToString` option in https://github.com/webpack/webpack/blob/42407cb5616aff940935cb58a4fda8429140c122/lib/Stats.js#L104 to skip heavy resource webpack stats
This shall reduce memory usage and improve performance
Test Plan