Updated element IDs for new Fastmail layout#70
Merged
joelekstrom merged 1 commit intojoelekstrom:masterfrom Feb 8, 2022
Merged
Updated element IDs for new Fastmail layout#70joelekstrom merged 1 commit intojoelekstrom:masterfrom
joelekstrom merged 1 commit intojoelekstrom:masterfrom
Conversation
Owner
|
Hi! Thanks for the patch. I think a better way may be to check the current URL perhaps? For example, when viewing a mail, |
Owner
|
Another idea is to somehow override the Fastmail bindings. In their source code they have this inside perhaps one could extend it and simply add the arrow shortcuts there. But I think the URL approach is simpler |
joelekstrom
added a commit
that referenced
this pull request
Aug 8, 2022
* In-app download support #82 Fastmate now downloads directly to a folder (which can be changed in settings) instead of opening an external browser. The old behavior can still be enabled in settings. * Add basic AppleScript support #81 * Add support for opening Fastmail https:// links #88 * Fix some shortcuts not working with new Fastmail layout #70 Big thanks to @mdbraber for all the work on these new features!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DOM changed with the latest UI refresh, so I updated the handlers to look for the new IDs.
A: This is fragile. There must be a better way.
B: The fact that we assure the document looks like we expected means we failed safely, so there's that.