[MRG+1] global func_with_kwonly_args, func_with_signature#713
Merged
lesteve merged 2 commits intojoblib:masterfrom Jul 4, 2018
Merged
[MRG+1] global func_with_kwonly_args, func_with_signature#713lesteve merged 2 commits intojoblib:masterfrom
lesteve merged 2 commits intojoblib:masterfrom
Conversation
Fixes joblib#711 Declare as global these two functions which are not created in the normal way. This PR helps both humans and linters to understand this unusual situation.
Codecov Report
@@ Coverage Diff @@
## master #713 +/- ##
==========================================
+ Coverage 95.02% 95.18% +0.15%
==========================================
Files 40 40
Lines 5747 5751 +4
==========================================
+ Hits 5461 5474 +13
+ Misses 286 277 -9
Continue to review full report at Codecov.
|
GaelVaroquaux
approved these changes
Jul 3, 2018
Member
GaelVaroquaux
left a comment
There was a problem hiding this comment.
This looks good. Thanks!
Member
|
I pushed some small tweaks, this can be merged if CIs are green. |
Member
|
I am going to ignore the codecov failure which is very likely due adding the functions that are actually never run. You can not please everyone I guess :-) ... |
Member
|
Merging thanks @cclaus! |
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Jul 28, 2018
* tag '0.12.1': Release 0.12.1 fix kwonlydefaults key error in filter_args (joblib#715) MNT fix some "undefined name" flake8 warnings (joblib#713). from importlib import reload for Python 3 (joblib#675) MTN vendor loky2.1.4 (joblib#708)
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Jul 28, 2018
* releases: (121 commits) Release 0.12.1 fix kwonlydefaults key error in filter_args (joblib#715) MNT fix some "undefined name" flake8 warnings (joblib#713). from importlib import reload for Python 3 (joblib#675) MTN vendor loky2.1.4 (joblib#708) Release 0.12 typo typo typo ENH add initializer limiting n_threads for C-libs (joblib#701) DOC better parallel docstring (joblib#704) [MRG] Nested parallel call thread bomb mitigation (joblib#700) MTN vendor loky2.1.3 (joblib#699) Make it possible to configure the reusable executor workers timeout (joblib#698) MAINT increase timeouts to make test more robust on travis DOC: use the .joblib extension instead of .pkl (joblib#697) [MRG] Fix exception handling in nested parallel calls (joblib#696) Fix skip test lz4 not installed (joblib#695) [MRG] numpy_pickle: several enhancements (joblib#626) Introduce Parallel.__call__ backend callbacks (joblib#689) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #711 Declare as global these two functions which are not created in the normal way. This PR helps both humans and linters to understand this unusual situation.