[MRG]: DeprecationWarning: invalid escape sequence in Python 3.6#526
Merged
lesteve merged 3 commits intojoblib:masterfrom Jun 1, 2017
Attractadore:feature
Merged
[MRG]: DeprecationWarning: invalid escape sequence in Python 3.6#526lesteve merged 3 commits intojoblib:masterfrom Attractadore:feature
DeprecationWarning: invalid escape sequence in Python 3.6#526lesteve merged 3 commits intojoblib:masterfrom
Attractadore:feature
Conversation
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
==========================================
- Coverage 93.78% 93.68% -0.11%
==========================================
Files 37 37
Lines 4779 4779
==========================================
- Hits 4482 4477 -5
- Misses 297 302 +5
Continue to review full report at Codecov.
|
Member
|
LGTM, thanks! Of course this is not tested so it is likely that other things like this will crop with time but oh well ... we will fix them when DeprecationWarnings turn into errors. |
Contributor
|
Thanks @Attractadore! |
gedakc
added a commit
to gedakc/manuskript
that referenced
this pull request
Nov 10, 2018
Fix by ensuring that regular expressions are constructed using either raw string literals [1] or double backslashes [2]. [1] https://stackoverflow.com/questions/44325948/pandas-invalid-escape-sequence-after-update [2] joblib/joblib#526 Note that python only shows the deprecation warnings on initial run [3]. [3] https://bugs.python.org/issue30091 To work around this issue, remove the cached bytecode with: find . -name "__pycache__" -exec rm -rf {} \; Then to prevent compiling to bytecode add the "-B" option to python: python3 -B -m pytest -vs
gedakc
added a commit
to gedakc/manuskript
that referenced
this pull request
Nov 16, 2018
Fix by ensuring that regular expressions are constructed using either raw string literals [1] or double backslashes [2]. [1] https://stackoverflow.com/questions/44325948/pandas-invalid-escape-sequence-after-update [2] joblib/joblib#526 Note that python only shows the deprecation warnings on initial run [3]. [3] https://bugs.python.org/issue30091 To work around this issue, remove the cached bytecode with: find . -name "__pycache__" -exec rm -rf {} \; Then to prevent compiling to bytecode add the "-B" option to python: python3 -B -m pytest -vs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If python 3.6 is run with the -Wd flags, DeprecationWarnings are thrown whenever a backslash is not used in an escape sequence. I fixed all these warnings, using raw strings where possible and double backslashes otherwise.