[MRG] Improve doc about caching methods#432
Merged
lesteve merged 1 commit intojoblib:masterfrom Dec 1, 2016
Merged
Conversation
Member
Author
|
@smidm do let me know if something is not crystal clear with the new doc, in particular if this would not have helped you on your particular issue. |
12b7011 to
8ff3055
Compare
Recommend to cache pure functions that you call inside a method
8ff3055 to
70ab78d
Compare
|
This would have pointed me in the right direction. Thanks. |
Member
Author
|
@aabadie @GaelVaroquaux maybe a quick look at this one? |
GaelVaroquaux
approved these changes
Nov 30, 2016
Member
GaelVaroquaux
left a comment
There was a problem hiding this comment.
Great rewrite. +1
I added a small comment on how I do things these days.
| @mem.cache # WRONG | ||
| def method(self, args): | ||
| pass | ||
| def compute(self): |
Member
There was a problem hiding this comment.
I actually now prefer to use joblib not as an decorator, but as an explicit function transformation, and I would remove the decorator on compute_func and write the following:
self.data = mem.cache(compute_func)(self.arg1, self.arg2, 40)
Member
Author
There was a problem hiding this comment.
I'll merge this PR and get rid of the mem.cache decorators in a separate PR.
Out of interest why do you do it this way, to make it clearer that the function is cached where it is called, to keep the uncached function easily accessible, for some other reasons?
Member
|
to keep the uncached function easily accessible, for some other reasons?
For that specific reason.
|
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Dec 8, 2016
* commit '0.10.2-55-g660fe5d': (52 commits) MAINT simplify way to skip doctests Do not print frames with IPython internals in format_stack BF(TST): compare for version in pickled filename ignoring full path, and looking for _ as well (joblib#445) [MRG] Remove nose dependency completely. (joblib#441) MAINT add Python 3.5 in setup.py Remove some Python 2.6 specific code [MRG] Make test execution on CI possible through py.test command. (joblib#433) Remove more python 2.6 related code (joblib#440) [MRG] Use commit range for diff in flake8_diff.sh (joblib#439) MAINT remove support for python 2.6 (joblib#437) Improve doc about caching methods (joblib#432) Get the tests passing with py.test MAINT update flake8_diff.sh COSMIT move stdlib imports where they belong [MRG] Replace assert_* methods with "assert" keyword statements. (joblib#430) Reraise when the exception is not a TransportableException (joblib#429) Make sure LICENSE.txt is included in the wheel Add LICENSE.txt Update doc/paralle.rst [MRG+1] Remove all nose imports from test scripts. (joblib#422) ...
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Dec 8, 2016
* releases: (52 commits) MAINT simplify way to skip doctests Do not print frames with IPython internals in format_stack BF(TST): compare for version in pickled filename ignoring full path, and looking for _ as well (joblib#445) [MRG] Remove nose dependency completely. (joblib#441) MAINT add Python 3.5 in setup.py Remove some Python 2.6 specific code [MRG] Make test execution on CI possible through py.test command. (joblib#433) Remove more python 2.6 related code (joblib#440) [MRG] Use commit range for diff in flake8_diff.sh (joblib#439) MAINT remove support for python 2.6 (joblib#437) Improve doc about caching methods (joblib#432) Get the tests passing with py.test MAINT update flake8_diff.sh COSMIT move stdlib imports where they belong [MRG] Replace assert_* methods with "assert" keyword statements. (joblib#430) Reraise when the exception is not a TransportableException (joblib#429) Make sure LICENSE.txt is included in the wheel Add LICENSE.txt Update doc/paralle.rst [MRG+1] Remove all nose imports from test scripts. (joblib#422) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recommend to cache pure functions that you call inside a method.
Add more information on caveats.
Initiated by #431.