Skip to content

borda/pyproject PR but with flake8 revert#1460

Closed
fcharras wants to merge 7 commits intojoblib:masterfrom
fcharras:borda/pyproject/amend_flake8
Closed

borda/pyproject PR but with flake8 revert#1460
fcharras wants to merge 7 commits intojoblib:masterfrom
fcharras:borda/pyproject/amend_flake8

Conversation

@fcharras
Copy link
Copy Markdown
Contributor

Add a commit to #1433 to keep the changes except the flake8 part.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (ebacd8c) 94.77% compared to head (6bc6d6e) 94.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1460      +/-   ##
==========================================
- Coverage   94.77%   94.71%   -0.06%     
==========================================
  Files          44       44              
  Lines        7306     7439     +133     
==========================================
+ Hits         6924     7046     +122     
- Misses        382      393      +11     

see 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thx @Borda and @fcharras

@Borda
Copy link
Copy Markdown
Contributor

Borda commented Jun 23, 2023

Not sure what to say when someone takes my work/PR and creates it as his contribution/PR 😕

@fcharras
Copy link
Copy Markdown
Contributor Author

@Borda I forked it to add a commit to revert the flake8 part but your original commits were not removed. You will still appear as the contributor of the commit.

@Borda
Copy link
Copy Markdown
Contributor

Borda commented Jun 23, 2023

I forked it to add a commit to revert the flake8 part but your original commits were not removed.

@fcharras any reason why you could not append your commit to the original PR?
when I'm looking for my work, the contribution won't be discovered by GH ()as far as I know)

Moreover, you could just ask me to do this change as you see was patient and responding fast

@tomMoral
Copy link
Copy Markdown
Contributor

We are in the process of releasing, we were in a hurry so we decided to finish the PR and to try to merge this quickly (we had a permission issue to push on yours).

We kept all your commit so you would have been credited anyway but if you mind this, we will merge the original pr. (We found out how to bypass the permission issue).

@tomMoral tomMoral closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants