Skip to content

merge all configs in pyproject.toml#1433

Merged
tomMoral merged 11 commits intojoblib:masterfrom
Borda:pyproject
Jun 23, 2023
Merged

merge all configs in pyproject.toml#1433
tomMoral merged 11 commits intojoblib:masterfrom
Borda:pyproject

Conversation

@Borda
Copy link
Copy Markdown
Contributor

@Borda Borda commented Apr 26, 2023

as pyproject.toml already exists in this repo and it is the new python standard, it makes sense to pull all particular configurations and drop redundant setup.cfg.

As Flake8 does not support pyproject.toml I have moved all essential arguments to the single call in CI 🐰

@codecov
Copy link
Copy Markdown

codecov bot commented May 1, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.10 ⚠️

Comparison is base (2edd849) 94.93% compared to head (9fcf7b2) 94.83%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1433      +/-   ##
==========================================
- Coverage   94.93%   94.83%   -0.10%     
==========================================
  Files          44       44              
  Lines        7439     7439              
==========================================
- Hits         7062     7055       -7     
- Misses        377      384       +7

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Borda
Copy link
Copy Markdown
Contributor Author

Borda commented May 1, 2023

@ogrisel @lesteve @tomMoral may I ask you for feedback? 🐰

@Borda
Copy link
Copy Markdown
Contributor Author

Borda commented Jun 13, 2023

friendly ping @ogrisel @lesteve @tomMoral 🦩

@fcharras fcharras mentioned this pull request Jun 23, 2023
Closed
@tomMoral
Copy link
Copy Markdown
Contributor

tomMoral commented Jun 23, 2023

This is a nice PR. We will keep setup.cfg for now to make it easy to run flake8 on the project but this is definitely a step in the right direction. Maybe it would make sense to move to ruff to drop flake8 and thus setup.cfg. PR welcome if you have the time :)

We just duplicated the PR in #1460 to be able to merge this before the release today.

@tomMoral tomMoral closed this Jun 23, 2023
@Borda
Copy link
Copy Markdown
Contributor Author

Borda commented Jun 23, 2023 •
edited
Loading

PR welcome if you have the time :)

@tomMoral, I feel confused when you welcome PR, but instead of adjusting mine/existing, you create a new one with another author... that is not a good way how to motivate anyone to contribute more, sorry 😞

Maybe it would make sense to move to ruff to drop flake8 and thus setup.cfg

That was my goal, but as I said not very happy 😕

@fcharras fcharras reopened this Jun 23, 2023
@Borda
Copy link
Copy Markdown
Contributor Author

Borda commented Jun 23, 2023

@fcharras @tomMoral so switch the flake8 t ruff in this PR or in another? doing it here would be trivial, just though to keep a PR minimal and focus

tomMoral
tomMoral approved these changes Jun 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Borda Borda mentioned this pull request Jun 23, 2023
Merged
@Borda @tomMoral
rewording
f224726 
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
@Borda
Copy link
Copy Markdown
Contributor Author

Borda commented Jun 23, 2023 •
edited
Loading

@tomMoral @fcharras thank you, and apology if I was too straight... 🐰

@Borda
Copy link
Copy Markdown
Contributor Author

Borda commented Jun 23, 2023

the failing docs build seems unrelated and appears on multiple PRs

@tomMoral
Copy link
Copy Markdown
Contributor

tomMoral commented Jun 23, 2023

Yes this was fixed in #1461 , the PR should now be green for merge

@tomMoral tomMoral merged commit 5d57f3d into joblib:master Jun 23, 2023
@Borda Borda deleted the pyproject branch July 6, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomMoral tomMoral tomMoral approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Borda @tomMoral @fcharras