Use inspect.signature() instead of inspect.getfullargspec()#1165
Use inspect.signature() instead of inspect.getfullargspec()#1165lesteve merged 6 commits intojoblib:masterfrom jwodder:signature
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1165 +/- ##
==========================================
+ Coverage 94.44% 94.48% +0.04%
==========================================
Files 47 47
Lines 6964 6997 +33
==========================================
+ Hits 6577 6611 +34
+ Misses 387 386 -1
Continue to review full report at Codecov.
|
lesteve
left a comment
There was a problem hiding this comment.
It has been a while since I looked at this code but this looks good at a first glance, thanks a lot for the PR!
Maybe someone else can have a second look? If nobody has some spare bandwidth I'll try to find more time to look at it in more details!
ogrisel
left a comment
There was a problem hiding this comment.
This looks good to me, thanks for the fix. Could you please document the fix in the changelog targeting the next release?
tomMoral
left a comment
There was a problem hiding this comment.
This looks neat! thx for the fix.
|
I added the CHANGES.rst entry and merged, thanks a lot @jwodder! |
Release 1.1.0 Fix byte order inconsistency issue during deserialization using joblib.load in cross-endian environment: the numpy arrays are now always loaded to use the system byte order, independently of the byte order of the system that serialized the pickle. joblib/joblib#1181 Fix joblib.Memory bug with the ignore parameter when the cached function is a decorated function. joblib/joblib#1165 Fix joblib.Memory to properly handle caching for functions defined interactively in a IPython session or in Jupyter notebook cell. joblib/joblib#1214 Update vendored loky (from version 2.9 to 3.0) and cloudpickle (from version 1.6 to 2.0) joblib/joblib#1218
Release 1.1.0 Fix byte order inconsistency issue during deserialization using joblib.load in cross-endian environment: the numpy arrays are now always loaded to use the system byte order, independently of the byte order of the system that serialized the pickle. joblib/joblib#1181 Fix joblib.Memory bug with the ignore parameter when the cached function is a decorated function. joblib/joblib#1165 Fix joblib.Memory to properly handle caching for functions defined interactively in a IPython session or in Jupyter notebook cell. joblib/joblib#1214 Update vendored loky (from version 2.9 to 3.0) and cloudpickle (from version 1.6 to 2.0) joblib/joblib#1218
Fixes #1164.