Drop Python 2 support by pierreglaser · Pull Request #1018 · joblib/joblib

pierreglaser · 2020-02-27T21:05:04Z

We're way past 1/1/2020.

codecov · 2020-02-27T21:09:14Z

Codecov Report

Merging #1018 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1018   +/-   ##
=======================================
  Coverage   94.12%   94.12%           
=======================================
  Files          46       46           
  Lines        6522     6522           
=======================================
  Hits         6139     6139           
  Misses        383      383

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd7140...3fd7140. Read the comment docs.

ogrisel

First pass.

joblib/test/test_hashing.py

joblib/test/test_logger.py

joblib/test/test_parallel.py

lesteve · 2020-03-24T07:20:36Z

Context: @mrocklin is looking at improving the dask/joblib integration in #1025, which is very welcome since my feeling (and I think @ogrisel's as well IIRC) was that there were a few quirks and I thought I would try to push this PR forward to make his life easier.

I had a few more passes at this PR. I am using this git grep to try to find remaining Python 2 things:

# the repetition in the last grep is to put back coloring on (there must be an easier way ...)
git grep -iP 'py(thon).*2' | grep -v externals | grep -iP 'py(thon).*2'

I have used python2_drop to indicate remaining issues to fix (maybe in separate PRs as @ogrisel hinted?). Those were the ones I was not 100% sure about in less than 1 minute
of thinking.

lesteve · 2020-03-25T01:48:21Z

Maybe @pierreglaser if you have some time to look at my changes ? My understanding is that @ogrisel will not have much time in the nex few weeks and it may be the same for me.

I noticed more things to clean up by using this git grep command, but I would be in favour of leaving that for a separate PR (as the python2_drop TODO I left in the code):

git grep -iP 'py(thon).*3' | grep -v externals

pierreglaser · 2020-03-25T09:55:16Z

Sure, I can make a pass this week.

pierreglaser · 2020-04-02T10:27:16Z

I'm also wondering whether or not we want to release a Python 2 compatible bugfix/minor release (that would include #966) before switching to a Python 3-only joblib.

joblib/_parallel_backends.py

joblib/format_stack.py

joblib/memory.py

tomMoral · 2020-04-03T08:44:41Z

Thanks @pierreglaser, this looks like tedious work!!

I did a small pass.

ogrisel

Few comments, but otherwise LGTM.

joblib/_parallel_backends.py

setup.py

pierreglaser · 2020-04-21T15:27:46Z

I gave a shot at restoring and deprecating various unused joblib construct we were about to simply delete. I also updated various meta-files (setup.py, CHANGES.rst, setup.cfg).

@ogrisel @tomMoral if you want to have a last look.

joblib/test/test_deprecated_objects.py

ogrisel

One more comment (above). Also don't forget to update the setup.cfg to remove the universal wheel flag.

joblib/test/test_deprecated_objects.py

ogrisel

I believe those are causing the linting failure.

joblib/test/test_deprecated_objects.py

Co-Authored-By: Olivier Grisel <olivier.grisel@gmail.com>

ogrisel · 2020-04-22T10:06:28Z

Rejoice \o/

ogrisel · 2020-04-22T10:06:40Z

Thanks very much @pierreglaser .

tomMoral · 2020-04-22T12:09:06Z

amazing!!! Thanks a lot @pierreglaser 😄

mrocklin · 2020-04-22T15:10:10Z

Woo!

…

On Wed, Apr 22, 2020 at 5:09 AM Thomas Moreau ***@***.***> wrote: amazing!!! Thanks a lot @pierreglaser <https://github.com/pierreglaser> 😄 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1018 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACKZTFFDQKKZMV4KE46HJDRN3M7BANCNFSM4K5DI7DQ> .

GaelVaroquaux · 2020-04-22T15:16:24Z

Yey!!!

https://build.opensuse.org/request/show/810898 by user dirkmueller + dimstar_suse - update to 0.15.1: - Make joblib work on Python 3 installation that do not ship with the lzma package in their standard library. - Drop support for Python 2 and Python 3.5. All objects in ``joblib.my_exceptions`` and ``joblib.format_stack`` are now deprecated and will be removed in joblib 0.16. Note that no deprecation warning will be raised for these objects Python < 3.7. joblib/joblib#1018 - Fix many bugs related to the temporary files and folder generated when automatically memory mapping large numpy arrays for efficient inter-process communication. In particular, this would cause `PermissionError` exceptions to be raised under Windows and large leaked files in `/dev/shm` under Linux in case of crash. https://github.c

pierreglaser changed the title ~~drop Python 2 entries in the CI~~ Drop Python 2 support Feb 27, 2020

pierreglaser changed the title ~~Drop Python 2 support~~ [WIP] Drop Python 2 support Feb 27, 2020

ogrisel reviewed Mar 4, 2020

View reviewed changes

lesteve mentioned this pull request Mar 23, 2020

Collect Dask results as they complete #1025

Merged

lesteve force-pushed the python3 branch from 4ce0ff9 to e9ad3dc Compare March 24, 2020 04:50

pierreglaser added 2 commits March 30, 2020 16:02

try to remove preparation code in failing example

e91e716

remove pickling workarounds related to old sphinx-gallery

431d4c3

tomMoral reviewed Apr 3, 2020

View reviewed changes

joblib/_parallel_backends.py Show resolved Hide resolved

tomMoral reviewed Apr 3, 2020

View reviewed changes

joblib/format_stack.py Outdated Show resolved Hide resolved

tomMoral reviewed Apr 3, 2020

View reviewed changes

joblib/memory.py Show resolved Hide resolved

Merge remote-tracking branch 'upstream/master'

550d66e

pierreglaser changed the title ~~[WIP] Drop Python 2 support~~ Drop Python 2 support Apr 20, 2020

ogrisel approved these changes Apr 21, 2020

View reviewed changes

joblib/_parallel_backends.py Show resolved Hide resolved

setup.py Show resolved Hide resolved

ogrisel mentioned this pull request Apr 21, 2020

[NoMRG] Update dataset used in the compressor comparision example #1031

Closed

pierreglaser and others added 10 commits April 21, 2020 10:02

drop Python 2 entries in the CI

e839125

remove all things related to PY3/PY2

ac4846a

make flake8 happy

eb6f67a

remove python2/python3 compat module

1774688

remove tokenize vendoring

eb2d152

cleanup more Python < 3.5 only branches

daab6ef

remove some Python 2 branches in tests

0faabdd

Tackle comments

5acb87c

Remove more Python 2 stuff.

0f62646

Remove wrong import.

7c3f7da

pierreglaser added 12 commits April 21, 2020 15:59

don't lint deprecated files

c585bcd

test deprecation warning for format_stack

7ac6536

Python<3.7:expose deprecated objs (no warning tho)

ec0fa1f

update setup.py - drop support for Python 3.5

30c0dc4

test joblib without numpy on Python 3.5 -> 3.6

cf220cd

avoid using python3.6 only syntax

e99a384

avoid name collisions in deprecation logic

df10964

use pypy 3.6 in the CI

7a9a7a1

update changelog

d8b0fee

restore deprecated objects tests

2f2d7df

actually raise DeprecationWarning

ea090ce

better use of pytest

3f1dabf

fixup! better use of pytest

fa8f915

ogrisel reviewed Apr 21, 2020

View reviewed changes

joblib/test/test_deprecated_objects.py Outdated Show resolved Hide resolved

ogrisel approved these changes Apr 21, 2020

View reviewed changes

joblib/test/test_deprecated_objects.py Outdated Show resolved Hide resolved

use import statements in deprecation tests

26e08f9

ogrisel mentioned this pull request Apr 22, 2020

Random timeout in test_nested_exception_dispatch #1034

Open

ogrisel reviewed Apr 22, 2020

View reviewed changes

joblib/test/test_deprecated_objects.py Outdated Show resolved Hide resolved

joblib/test/test_deprecated_objects.py Outdated Show resolved Hide resolved

flake8 - unused imports

3fd7140

Co-Authored-By: Olivier Grisel <olivier.grisel@gmail.com>

pierreglaser mentioned this pull request Apr 22, 2020

joblib now logs to joblib namespace and no longer adds a stream handler to the root logger. #1033

Closed

ogrisel merged commit c98b694 into joblib:master Apr 22, 2020

andersy005 mentioned this pull request May 23, 2020

ModuleNotFoundError when using joblib v0.15.0 or later bmabey/provenance#60

Closed

lesteve mentioned this pull request Jul 1, 2020

Remove lingering possibly Python 2 specific things #1079

Open

Conversation

pierreglaser commented Feb 27, 2020

Uh oh!

codecov bot commented Feb 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ogrisel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lesteve commented Mar 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lesteve commented Mar 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pierreglaser commented Mar 25, 2020

Uh oh!

pierreglaser commented Apr 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tomMoral commented Apr 3, 2020

Uh oh!

ogrisel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pierreglaser commented Apr 21, 2020

Uh oh!

Uh oh!

ogrisel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ogrisel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ogrisel commented Apr 22, 2020

Uh oh!

ogrisel commented Apr 22, 2020

Uh oh!

tomMoral commented Apr 22, 2020

Uh oh!

mrocklin commented Apr 22, 2020 via email

Uh oh!

GaelVaroquaux commented Apr 22, 2020 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Feb 27, 2020 •

edited

Loading

lesteve commented Mar 24, 2020 •

edited

Loading

lesteve commented Mar 25, 2020 •

edited

Loading

pierreglaser commented Apr 2, 2020 •

edited

Loading