Skip to content

Disable pr env in main branch#31

Merged
joaomcteixeira merged 14 commits intomainfrom
prbug
Jul 14, 2022
Merged

Disable pr env in main branch#31
joaomcteixeira merged 14 commits intomainfrom
prbug

Conversation

@joaomcteixeira
Copy link
Copy Markdown
Owner

@joaomcteixeira joaomcteixeira commented Jul 14, 2022

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #31 (b29b9d8) into main (629a99a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files           4        4           
  Lines          15       15           
  Branches        1        1           
=======================================
  Hits           14       14           
  Misses          1        1           
Impacted Files Coverage Δ
src/sampleproject/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a92b749...b29b9d8. Read the comment docs.

@joaomcteixeira joaomcteixeira merged commit 2a6cc4b into main Jul 14, 2022
@joaomcteixeira joaomcteixeira deleted the prbug branch July 14, 2022 10:21
@joaomcteixeira joaomcteixeira added the bug Something isn't working label Jul 14, 2022
joaomcteixeira added a commit that referenced this pull request Jul 14, 2022
Disable `pr` env in `main` branch (#31)
# workaround to ignore 'pr' when merging to main
# see: https://github.community/t/how-to-conditionally-include-exclude-items-in-matrix-eg-based-on-branch/16853/6
isMerge:
- ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anyone reaching this PR trying to make the exclusion work with a boolean input, called useBeta for example, (workflow_dispatch) I had to use ${{ inputs.useBeta }} instead of ${{ github.event.inputs.useBeta }}. I think it is because inputs maintains the boolean whilst github.events.inputs converts it to string: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#providing-inputs

By the way, very useful example here, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants