Merged
Conversation
8b945b3 to
097f2b8
Compare
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 9 9
Lines 635 635
=======================================
Hits 633 633
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hugovk
requested changes
Feb 27, 2022
Collaborator
hugovk
left a comment
There was a problem hiding this comment.
Thank you very much for this, nice improvements!
- Don't allow to select
>>>text nodes inside codeblocks. Forpyconcode blocks uses the recipe suggested by mkdocstrings and forpythoncodeblocks a Javascript function with a CSS class.
I'm not sure if this is working?
For example, at /number/#humanize.number.clamp, when I click the "Copy to clipboard icon", it copies this:
>>> clamp(123.456)
'123.456'
>>> clamp(0.0001, floor=0.01)
'<0.01'
>>> clamp(0.99, format="{:.0%}", ceil=0.99)
'99%'
>>> clamp(0.999, format="{:.0%}", ceil=0.99)
'>99%'
>>> clamp(1, format=intword, floor=1e6, floor_token="under ")
'under 1.0 million'
>>> clamp(None) is None
True
Should it instead copy something like this?
clamp(123.456)
clamp(0.0001, floor=0.01)
clamp(0.99, format="{:.0%}", ceil=0.99)
clamp(0.999, format="{:.0%}", ceil=0.99)
clamp(1, format=intword, floor=1e6, floor_token="under ")
clamp(None) is None
|
We should probably use |
Contributor
Author
Opened an issue in mkdocs-material#3647 and seems that the unique solution would be to hide the "Copy to clipboard" buttons. I've pinned |
|
I didn't know about that pygment option, I'm not sure how to include these CSS rules by default in the new Python handler now 😕 Maybe we shouldn't include them by default, as pointed out in the issue you opened. |
Contributor
Author
I agree, what do you think @hugovk? |
Collaborator
|
Sure, fine to disable it. The Sphinx version of the copy button can strip out Thanks! |
hugovk
approved these changes
Mar 6, 2022
Collaborator
|
Thanks! |
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
May 27, 2022
Changelog:
==========
Added
------
Support Python 3.11 (openembedded#13)
Add Arabic language (jmoiron/humanize#256)
Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
Documentation improvements (jmoiron/humanize#254)
Changed
-------
Update repo links (openembedded#2)
Fixed
-------
Removed VERSION from __all__ (openembedded#11)
Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
May 27, 2022
Changelog:
==========
Added
------
Support Python 3.11 (openembedded#13)
Add Arabic language (jmoiron/humanize#256)
Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
Documentation improvements (jmoiron/humanize#254)
Changed
-------
Update repo links (openembedded#2)
Fixed
-------
Removed VERSION from __all__ (openembedded#11)
Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
May 27, 2022
Changelog:
==========
Added
------
Support Python 3.11 (openembedded#13)
Add Arabic language (jmoiron/humanize#256)
Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
Documentation improvements (jmoiron/humanize#254)
Changed
-------
Update repo links (openembedded#2)
Fixed
-------
Removed VERSION from __all__ (openembedded#11)
Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
May 28, 2022
Changelog:
==========
Added
------
Support Python 3.11 (openembedded#13)
Add Arabic language (jmoiron/humanize#256)
Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
Documentation improvements (jmoiron/humanize#254)
Changed
-------
Update repo links (openembedded#2)
Fixed
-------
Removed VERSION from __all__ (openembedded#11)
Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
May 28, 2022
Changelog:
==========
Added
------
Support Python 3.11 (openembedded#13)
Add Arabic language (jmoiron/humanize#256)
Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
Documentation improvements (jmoiron/humanize#254)
Changed
-------
Update repo links (openembedded#2)
Fixed
-------
Removed VERSION from __all__ (openembedded#11)
Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
May 28, 2022
Changelog:
==========
Added
------
Support Python 3.11 (openembedded#13)
Add Arabic language (jmoiron/humanize#256)
Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
Documentation improvements (jmoiron/humanize#254)
Changed
-------
Update repo links (openembedded#2)
Fixed
-------
Removed VERSION from __all__ (openembedded#11)
Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
May 28, 2022
Changelog:
==========
Added
------
Support Python 3.11 (openembedded#13)
Add Arabic language (jmoiron/humanize#256)
Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
Documentation improvements (jmoiron/humanize#254)
Changed
-------
Update repo links (openembedded#2)
Fixed
-------
Removed VERSION from __all__ (openembedded#11)
Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
May 29, 2022
Changelog:
==========
Added
------
Support Python 3.11 (openembedded#13)
Add Arabic language (jmoiron/humanize#256)
Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
Documentation improvements (jmoiron/humanize#254)
Changed
-------
Update repo links (openembedded#2)
Fixed
-------
Removed VERSION from __all__ (openembedded#11)
Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
clamp()arguments not being correctly rendered withmkdocstrings.include-markdownplugin to include "Usage" section of README inside Home.>>>text nodes inside codeblocks. Forpyconcode blocks use the recipe suggested by mkdocstringsand for.pythoncodeblocks a Javascript function with a CSS classmkdocstrings[python-legacy]>=0.18). See About the Python handlers in mkdocstrings documentation.