fix #172: DeterministicScheduler supports customizable tick precision#173
Merged
Conversation
…e tick precision This change adds a constructor which takes a TimeUnit for custom precision, but does not modify the default constructor in order to avoid breaking existing tests which could overflow a long using very long periods of time.
7e2c7a3 to
75bd3ec
Compare
carterkozak
added a commit
to palantir/dialogue
that referenced
this pull request
Feb 28, 2020
This prevents us from attempting to go back in time. Without allowing small time-slip we can build confidence that new functionality doesn't cause us to regress. Fork will be unnecessary if the upstream fix is accepted: jmock-developers/jmock-library#172 jmock-developers/jmock-library#173
carterkozak
added a commit
to palantir/dialogue
that referenced
this pull request
Feb 28, 2020
This prevents us from attempting to go back in time. Without allowing small time-slip we can build confidence that new functionality doesn't cause us to regress. Fork will be unnecessary if the upstream fix is accepted: jmock-developers/jmock-library#172 jmock-developers/jmock-library#173
Member
|
I'm thinking ticks could be a java.time.Duration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a constructor which takes a TimeUnit for custom
precision, but does not modify the default constructor in order to
avoid breaking existing tests which could overflow a long using
very long periods of time.