Add a go.mod file to support Go modules.#39
Merged
jmhodges merged 1 commit intojmhodges:masterfrom Feb 28, 2019
creachadair:gomod
Merged
Add a go.mod file to support Go modules.#39jmhodges merged 1 commit intojmhodges:masterfrom creachadair:gomod
jmhodges merged 1 commit intojmhodges:masterfrom
creachadair:gomod
Conversation
In order to work well with [Go modules][gomod], packages should have a `go.mod` file and semantic version tags on release versions. Here I have provided a rudimentary `go.mod` file for levigo. If you accept this change, and if you are willing to also `git tag v0.0.1 master` and `git push origin v0.0.1` after it is merged, that would begin the release history. I don't know whether you consider the API stable enough for a v1.0.0 release, but users will expect stability so v0 is a safe default. [gomod]: https://github.com/golang/go/wiki/Modules
Owner
|
Wilco! Thanks! |
Owner
|
(And done as v1.0.0) |
Contributor
Author
|
Thank you! |
nmlgc
pushed a commit
to nmlgc/janelia-flyem-go
that referenced
this pull request
Oct 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to work well with Go modules, packages should have a
go.modfile and semantic version tags on release versions.Here I have provided a rudimentary
go.modfile for levigo. If you accept this change, and if you are willing to alsogit tag v0.0.1 masterandgit push origin v0.0.1after it is merged, that would begin the release history. I don't know whether you consider the API stable enough for a v1.0.0 release, but users will expect stability so v0 is a safe default.