-
Notifications
You must be signed in to change notification settings - Fork 6
Significant feature upgrades #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nd status output order
…ls in verbose mode
|
Thanks for the updates! Looks like there are still some test failures. I'm happy to keep kicking off the build when you push changes :) |
|
Yeah, Ive got a hellish week. Not sure ill get to it this week. Sorry.
…On Mon, Apr 21, 2025 at 1:57 PM John M Daly ***@***.***> wrote:
Thanks for the updates! Looks like there are still some test failures. I'm
happy to keep kicking off the build when you push changes :)
—
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAOQV7SEZRSZCS4GBEIEYL22VLS3AVCNFSM6AAAAAB3CDHGA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJZGQ4TANBSG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
*jmdaly* left a comment (jmdaly/llm-github-copilot#9)
<#9 (comment)>
Thanks for the updates! Looks like there are still some test failures. I'm
happy to keep kicking off the build when you push changes :)
—
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAOQV7SEZRSZCS4GBEIEYL22VLS3AVCNFSM6AAAAAB3CDHGA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJZGQ4TANBSG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
No problem at all! |
feat(src/main/java/com/example/Main.java): ✨ Introduce processItems to encapsulate list processing test(src/test/java/com/example/MainTest.java): 🚨 Add unit test to verify processItems method output
feat(TextToBigQueryStreaming.java): ✨ Add options to use BigQuery Storage Write API for improved streaming performance. test(TextToBigQueryStreamingIT.java): 🚨 Add integration tests to validate streaming to BigQuery using the Storage Write API.
fix(packages/eslint-plugin-lit-a11y/lib/rules/no-redundant-role.js): 🐛 Use isInteractiveElement to improve redundant role detection feat(packages/eslint-plugin-lit-a11y/lib/utils/isInteractiveElement.js): ✨ Add utility to check if an element is interactive based on tag and attributes test(packages/eslint-plugin-lit-a11y/tests/lib/rules/no-redundant-role.js): 🚨 Add tests for redundant roles on various interactive elements # hore: Refactor llm-github-copilot plugin for maintainability
fix(packages/core/src/components/discord-attachment/discord-attachment.tsx): 🐛 Add slot="attachment" to anchor element to ensure correct placement and styling within parent components. refactor(packages/core/src/components/discord-attachments/discord-attachments.tsx): ♻️ Remove span wrapper around default slot, as individual attachments now use a named slot.
|
Give it a run now. All the tests are passing on my system. |
|
Oh, and just an fyi, the commit messages are borked, my llm commit message generator went off the rails and hallucinated like a bad acid trip... |
|
Awesome, thanks for doing this! Haha, no worries about the commit messages - I like to use llms to generate them as well :) My one comment is about changing |
|
Good question I should have documented that better. The reason I changed that is because github_copilot seems to be the emergent standard being used by things like litellm where they refer to copilot models like github_copilot/claude-3.5-sonnet I was trying to align to the that because that is also how a tool like aider would refer to the model. |
|
You could do a hybrid where the cli uses llm github-copilot with a dash, but the models returns things with an underscore. I thought using both depending on context just caused more confusion. |
|
Alright sounds great! Thanks again for the contribution :) I'll publish a release to PyPi in the next couple days |
This started out simply, I was not happy with the original implementation that after install it would force an authentication. I ended up going down the rabbit hold.
Heavy use of aider to develop this. It was my first time using it and I was quite impressed.