Skip to content

Conversation

@cavanaug
Copy link
Contributor

This started out simply, I was not happy with the original implementation that after install it would force an authentication. I ended up going down the rabbit hold.

  • subcommand for this plugin
  • added auth command with login/logout/status/refresh
  • added tests for these sub commands
  • added support for environment variable for auth
  • added support to use the default llm config folders
  • added support to use the default llm keystore

Heavy use of aider to develop this. It was my first time using it and I was quite impressed.

cavanaug added 30 commits April 12, 2025 04:43
@jmdaly
Copy link
Owner

jmdaly commented Apr 21, 2025

Thanks for the updates! Looks like there are still some test failures. I'm happy to keep kicking off the build when you push changes :)

@cavanaug
Copy link
Contributor Author

cavanaug commented Apr 22, 2025 via email

@jmdaly
Copy link
Owner

jmdaly commented Apr 22, 2025

Yeah, Ive got a hellish week. Not sure ill get to it this week. Sorry.

No problem at all!

cavanaug added 6 commits May 20, 2025 23:43
feat(src/main/java/com/example/Main.java): ✨ Introduce processItems to encapsulate list processing
test(src/test/java/com/example/MainTest.java): 🚨 Add unit test to verify processItems method output
feat(TextToBigQueryStreaming.java): ✨ Add options to use BigQuery Storage Write API for improved streaming performance.
test(TextToBigQueryStreamingIT.java): 🚨 Add integration tests to validate streaming to BigQuery using the Storage Write API.
fix(packages/eslint-plugin-lit-a11y/lib/rules/no-redundant-role.js): 🐛 Use isInteractiveElement to improve redundant role detection
feat(packages/eslint-plugin-lit-a11y/lib/utils/isInteractiveElement.js): ✨ Add utility to check if an element is interactive based on tag and attributes
test(packages/eslint-plugin-lit-a11y/tests/lib/rules/no-redundant-role.js): 🚨 Add tests for redundant roles on various interactive elements

# hore: Refactor llm-github-copilot plugin for maintainability
fix(packages/core/src/components/discord-attachment/discord-attachment.tsx): 🐛 Add slot="attachment" to anchor element to ensure correct placement and styling within parent components.
refactor(packages/core/src/components/discord-attachments/discord-attachments.tsx): ♻️ Remove span wrapper around default slot, as individual attachments now use a named slot.
@cavanaug
Copy link
Contributor Author

Give it a run now. All the tests are passing on my system.

@cavanaug
Copy link
Contributor Author

Oh, and just an fyi, the commit messages are borked, my llm commit message generator went off the rails and hallucinated like a bad acid trip...

@jmdaly
Copy link
Owner

jmdaly commented May 22, 2025

Awesome, thanks for doing this! Haha, no worries about the commit messages - I like to use llms to generate them as well :) My one comment is about changing github-copilot to github_copilot. Curious if there was a technical reason for this? If not, it looks like the other llm plugins tend to use dashes

@cavanaug
Copy link
Contributor Author

Good question I should have documented that better. The reason I changed that is because github_copilot seems to be the emergent standard being used by things like litellm where they refer to copilot models like

github_copilot/claude-3.5-sonnet
github_copilot/claude-3.7-sonnet

I was trying to align to the that because that is also how a tool like aider would refer to the model.

@cavanaug
Copy link
Contributor Author

You could do a hybrid where the cli uses llm github-copilot with a dash, but the models returns things with an underscore. I thought using both depending on context just caused more confusion.

@jmdaly jmdaly merged commit 12f3c2a into jmdaly:main May 24, 2025
5 checks passed
@jmdaly
Copy link
Owner

jmdaly commented May 24, 2025

Alright sounds great! Thanks again for the contribution :) I'll publish a release to PyPi in the next couple days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants