Skip to content

Add ID mappings for mushroom blocks and mycelium#225

Closed
ILikePlayingGames wants to merge 1 commit into
jmc2obj:masterfrom
ILikePlayingGames:add-id-mappings
Closed

Add ID mappings for mushroom blocks and mycelium#225
ILikePlayingGames wants to merge 1 commit into
jmc2obj:masterfrom
ILikePlayingGames:add-id-mappings

Conversation

@ILikePlayingGames

Copy link
Copy Markdown

One step towards #209

@ILikePlayingGames

Copy link
Copy Markdown
Author

BTW, is there a way to import the original states from the world instead of setting a static state?

@mmdanggg2 mmdanggg2 closed this in 4dfbe3c Jul 30, 2023
@mmdanggg2

Copy link
Copy Markdown
Collaborator

Thanks for pointing that out.
Pre 1.13, blocks only had the data values byte, that's all we have to calculate block states.

@ILikePlayingGames

Copy link
Copy Markdown
Author

@mmdanggg2 Thanks! Would it be possible to add a warning when a block doesn’t have a texture? When I was rendering the preview the mushroom showed purple but I didn’t see any console warnings.

@mmdanggg2

Copy link
Copy Markdown
Collaborator

I've added a debug log for when a texture couldn't be found for a block so that should help that specific situation.

That alerted me that observers were not converted correctly so that's fixed too now. And on top of that the observers resource pack model was not computed correctly so I've fixed an issue with the model readier too which affected a couple of blocks; very helpful little rabbit hole!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants