Jline 2.12 fix alt gr#175
Jline 2.12 fix alt gr#175trptcolin merged 2 commits intojline:masterfrom michael72:jline-2.12-fix-alt-gr
Conversation
…sed along with the Alt key
…sed along with the Alt key
|
Thanks for digging into this! Looks good to me - @fantasy86 any concerns before I merge this? |
|
Greetings from the Scala team! Our users (especially beginners) ran into this problem and reported it in multiple venues: https://groups.google.com/forum/#!topic/scala-user/TphB1s6ad7E Would it possible to cut a release of jline2 right after the fix is merged? We would love ship jline version including this fix ASAP to improve experience of newcomers to Scala. I'm guessing Clojure folks would follow the suite. |
|
This is really great! Many thanks to Michael! I'm helping many beginners to get going with Scala, so it would be really good to have a new jline release as soon as possible. Thanks again for your work. |
|
+1! |
|
great! |
|
I was wondering if this might make it into a jline release soon? We're releasing new versions of Scala and would like to include this fix. Thanks! |
|
I was wondering if there is still any activity on this project at all... There haven't been any changes the last 8 months! |
|
Great news that this is now merged into master! @trptcolin How soon can we perhaps expect a new release of jline? |
|
can spin a release, anything else need to be considered @trptcolin ? |
|
Thank you! By the way, we use Travis to automate our releases (using Travis's support for encryption to keep the keys/passwords safe). Happy to elaborate on our setup, which was refined most recently in scala/scala-java8-compat#20 (some more info in the original PR at scala/scala-swing#33). We use sbt, but it should be straightforward to adapt to maven. The idea is that the tag's name determines the version to release. Once Travis is done, you close the staging repo on sonatype, double check & promote: scala/scala-swing#37 (comment). |
|
FTR I've no objection to setting up travis to implement CI and release-automation, but I personally don't have time to investigate and set it up. So unless someone wants to push forward on that, its still less effort for me to spin the build locally when requested (which doesn't happen often). |
|
I'm not aware of anything else that's ready to go right now, but haven't been keeping a close eye on jline. I'd also enjoy TravisCI release automation but won't have time to work on it for awhile. |
|
Fair enough -- completely understood. Just throwing it out there :-) Really appreciate getting this fix out! We'll highlight the fix in our release notes and try to get contributors to help out. |
|
2.12.1 staged: https://oss.sonatype.org/content/repositories/jline-1001 Tests and let me know if its happy to pull release trigger. |
|
Thanks! I cross-posted to https://issues.scala-lang.org/browse/SI-8759 |
|
Eh, so ... no feedback yet on release candidate? @trptcolin @adriaanm @michael72 I guess if I don't hear anything, I'll pull the release trigger. |
|
I unfortunately don't have one of those keyboards, so I can't verify. I pinged the OP over on our issue tracker. Sorry about the delay! |
|
Yeah, same, I don't have any way to test this. |
|
OK - I just tested it - so in comparison to the old 2.12. inserting a simple ']' worked just fine with the 2.12.1 |
|
The new 2.12.1 jar works fine on my win7 box. I can make Alt keys on a swedish keyboard, such as [ and ] |
|
🎆 Thanks again, everybody! |
Users of German & Swedish keyboards can again type `]` in the REPL without crazy acrobatics. Fixed upstream in jline/jline2#175
|
jline 2.12.1 released, should get sync'd to central in a few hours |
As the code checking for "Alt" key pressed does not check for "Ctrl" key pressed, some insertions using "Alt Gr" key (which is mapped to Ctrl-Alt on Windows) will not work.
I added an additional check for the Ctrl key.