Conversation
for static linking
libcurl build recipe
1. tweaks in control file (name, url, git, etc) 2. package script 3. changelog
Debian package for komodo
hotfix for excessive fees
spelling, grammar etc.
README.md updates
Hot fix for btc $4294 price overflow, no need to update if you dont use paxprice
paxprice fixes, no need to update if you dont run pax fiat assetchains
removes pax prints
change download link from z.cash
change download link from z.cash. no need to update if you already have built komodod
universal cross platform source tree
fix the build issue from missing zcash repo file
…ecause that disables shared linking. cryptoconditions must not include config.h because that includes conflicting variables.
Author
|
Updated to latest jl777/dev, including zcash upgrade |
Author
|
Also removed replacementpool entirely. |
Author
|
Added cross chain payout functions, not tested yet |
…as requiring a signature and limiting types * different SIGHASH types for CC
c099b0e to
563581a
Compare
Author
|
Some extra validations for malleability and supported CC types |
9bba38c to
561f3e1
Compare
* restrict lengths in cryptoconditions to avoid ridiculous situations
1742d9f to
e36af93
Compare
dimxy
pushed a commit
to dimxy/komodo
that referenced
this pull request
Jul 12, 2022
HF22 (HFNET) Consensus Changes
miketout
pushed a commit
to miketout/VerusCoin
that referenced
this pull request
Nov 16, 2023
Release v1.1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's left to do before merge?
Add to this list:
Revisit reorg behaviour w/r/t replacementPool (second replacementWindow?)or Replacement pool(arent any!)Enabling
Currently, Crypto-Conditions is enabled via a command line flag. It probably makes sense to enable to by default for some chains after a certain block height.
What types of Crypto-Condition are acceptable?
I'm guessing we only want:
Also guessing that we'll accept any fulfillment that fits into a ~500 byte opcode. It's not a huge amount of space.
Documentation
I want to point out that "src/cryptoconditions" is actually tracking the komodo branch of libscott/libcryptoconditions, but I'm not using a submodule anymore, all files are committed. In practice you can run
git initinside the subfolder and manage that subtree, and the .git folder will be ignored in by parent (komodo). Is there anywhere that it makes sense to document this?