Skip to content

Dev#130

Merged
jl777 merged 96 commits intobetafrom
dev
Jan 25, 2017
Merged

Dev#130
jl777 merged 96 commits intobetafrom
dev

Conversation

@jl777
Copy link
Copy Markdown
Owner

@jl777 jl777 commented Jan 25, 2017

rebase to zcash 1.0.5

str4d and others added 30 commits December 9, 2016 21:06
…checkpoints, r=str4d

Skip JoinSplit verification before the last checkpoint

Part of #1749
Additional well-formedness check for G2 elements

libsnark currently checks that G<sub>1</sub> and G<sub>2</sub> elements are well-formed by ensuring that they satisfy their respective curve equations, and although this is enough for G<sub>1</sub> (which is instantiated as an order r curve E/F<sub>p</sub>: y^2 = x^3 + b), G<sub>2</sub> is the order r *subgroup* of the composite order r(2q-r) curve E'/Fp<sup>2</sup>: y^2 = x^3 + b/e constructed via a sextic twisting isomorphism. This means we need to ensure these points are order r as well.

None of the proofs on the Zcash blockchain violate this check, and it may not even be possible for them to violate this check (bilinearity is not preserved). Let's be cautious and do it anyway.
Only increment new notes on reindex

Addresses another issue in zcash#1904.

When an existing one of our notes was found again, its cache was reset and it was re-witnessed. This would cause encountered notes to get out-of-sync with the otherwise-ignored newer notes, which could be a problem if the wallet data happens to be written out during a reindex.
…ebfull

Add total number of commitments to getblockchaininfo
after a successful sign and send, meaning that the logged hash fragment
would be different from the txid logged by "AddToWallet".  This issue
occured when sending from transparent addresses, as utxo inputs must be
signed.  It did not occur when sending from shielded addresses.
zkbot and others added 27 commits January 18, 2017 04:29
…es, r=ebfull

Fixes zcash#1967 by adding age of note to z_sendmany logging.
… r=ebfull

Fix bug where z_sendmany logged incorrect txid fragment when sending from taddr

Closes zcash#1987.
Rename build-aux/m4/bitcoin_find_bdb48.m4 to remove version

Closes #1622.
…s, r=ebfull

Closes zcash#1957 by adding tx serialization size to listtransactions output.
rpc: Implement random-cookie based authentication

Cherry-picked from bitcoin/bitcoin#6388.

Closes zcash#1950.
…_when_exporting, r=bitcartel

Fixes #1497 ZCA-009 by restricting export to a user defined folder and sanitizing filenames
…e, r=ebfull

Add missing header

Closes zcash#2027 where gcc 6.2.0 identified that `rpcwallet.cpp` was missing a header file `<numeric>` which is required due to usage of `std::accumulate`.
…r=bitcartel

Closes #1097 so that zcash-cli displays license info like zcashd.

LicenseInfo is refactored from init.cpp to util.cpp so that the
bitcoin-cli makefile target does not need to be modified.
…=bitcartel

Instruct users to run zcash-fetch-params if network params aren't available

Closes #1786.
…, r=ebfull

Scan the whole chain whenever a z-key is imported

Closes zcash#1941.
# Conflicts:
#	.gitignore
#	README.md
#	src/Makefile.gtest.include
#	src/gtest/test_checkblock.cpp
#	src/init.cpp
#	src/main.cpp
#	src/main.h
#	src/rpcserver.cpp
#	src/test/checkblock_tests.cpp
#	src/util.cpp
@jl777 jl777 merged commit 9554372 into beta Jan 25, 2017
miketout referenced this pull request in miketout/VerusCoin Oct 24, 2018
Fix incorrect voutNum and ensure that voutNum is of output with value
jl777 pushed a commit that referenced this pull request Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants