Skip to content

Add some helpers#209

Merged
jknack merged 5 commits into
jknack:masterfrom
Jarlakxen:master
Jul 24, 2013
Merged

Add some helpers#209
jknack merged 5 commits into
jknack:masterfrom
Jarlakxen:master

Conversation

@Jarlakxen

Copy link
Copy Markdown

I think that they are generic and quite useful.

@jknack

jknack commented Jul 24, 2013

Copy link
Copy Markdown
Owner

hey looks good!

make sure to run: mvn clean package and fix any test or checkstyle error you see there. Travis said the build is broken and can't be merged it.

will make a quick review of what I see...

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add javadoc

@Jarlakxen

Copy link
Copy Markdown
Author

Thanks! i'm going to fix the checkstyle errors and fix the javadoc

@jknack

jknack commented Jul 24, 2013

Copy link
Copy Markdown
Owner

np, you're welcome

@Jarlakxen

Copy link
Copy Markdown
Author

It's done

@jknack

jknack commented Jul 24, 2013

Copy link
Copy Markdown
Owner

cool!

jknack added a commit that referenced this pull request Jul 24, 2013
@jknack jknack merged commit 1b593b8 into jknack:master Jul 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants