ENH Rework PairwiseDistancesArgKmin to use a class method .compute
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
reviewed
Dec 1, 2021
ogrisel
approved these changes
Dec 1, 2021
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
ogrisel
reviewed
Dec 1, 2021
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Owner
Author
|
WDYT, @thomasjpfan? |
thomasjpfan
reviewed
Dec 2, 2021
This computes the exact number of threads needed (effective threads) at the initialisation. This allows allocating the exact number of pointers that we need. This also allows removing the `num_threads` parameters from the callbacks methods' signatures (as the information is now accessible via an attribute). Co-authored-by: Jérémie du Boisberranger <jeremiedbb@users.noreply.github.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
reviewed
Dec 21, 2021
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
reviewed
Dec 21, 2021
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
This was mentionned by one of Oliviers' review but I forgot it. Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
thomasjpfan
reviewed
Dec 22, 2021
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Owner
Author
|
Merging based on @thomasjpfan's last comment: #5 (review) I'll update the plan with this sub-PR reviews' comments that I see there. |
10 tasks
jjerphan
pushed a commit
that referenced
this pull request
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Small rework for scikit-learn#21462
What does this implement/fix? Explain your changes.
Addresses discussions in https://github.com/scikit-learn/scikit-learn/pull/21462/files#r744318407
cc @thomasjpfan